rayan/bruno
1
0
Fork 0
mirror of https://github.com/usebruno/bruno.git synced 2026-06-11 09:51:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: 3093 - Fix pm.setNextRequest(null) not translating to bru.runner.stopExecution() (#8049)

Browse Source 
* fix: 3093 - Fix pm.setNextRequest(null) not translating to bru.runner.stopExecution()

* addressed review comments

* addressed review comments
This commit is contained in:
sharan-bruno
2026-05-20 19:22:55 +05:30
committed by GitHub
parent 023630338b
commit 4b214693c4
5 changed files with 49 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/bruno-converters/src/postman/postman-translations.js
View File

@@ -15,7 +15,9 @@ const replacements = {
// 'pm\\.collectionVariables\\.unset\\(': 'bru.deleteCollectionVar(',
// 'pm\\.collectionVariables\\.clear\\(': 'bru.deleteAllCollectionVars(',
// 'pm\\.collectionVariables\\.toObject\\(': 'bru.getAllCollectionVars(',
'pm\\.setNextRequest\\(': 'bru.setNextRequest(',
'pm\\.setNextRequest\\(null\\)': 'bru.runner.stopExecution()',
'pm\\.setNextRequest\\([\'\"]null[\'\"]\\)': 'bru.runner.stopExecution()',
'pm\\.setNextRequest\\(': 'bru.runner.setNextRequest(',
'pm\\.test\\(': 'test(',
'pm.response.to.have\\.status\\(': 'expect(res.getStatus()).to.equal(',
'pm\\.response\\.to\\.have\\.status\\(': 'expect(res.getStatus()).to.equal(',

26
packages/bruno-converters/src/utils/postman-to-bruno-translator.js
View File

@@ -41,9 +41,6 @@ const simpleTranslations = {
// 'pm.collectionVariables.clear': 'bru.deleteAllCollectionVars',
// 'pm.collectionVariables.toObject': 'bru.getAllCollectionVars',
// Request flow control
'pm.setNextRequest': 'bru.setNextRequest',
// Testing
'pm.test': 'test',
'pm.expect': 'expect',
@@ -267,6 +264,29 @@ const complexTransformations = [
}
})),
// Handle pm.setNextRequest(null) / pm.setNextRequest('null') — stop the runner
{
pattern: 'pm.setNextRequest',
transform: (path, j) => {
const callExpr = path.parent.value;
const args = callExpr.arguments;
if (
args[0] && args[0].type === 'Literal' && (args[0].value === null || args[0].value === 'null')
) {
return j.callExpression(
j.identifier('bru.runner.stopExecution'),
[]
);
}
return j.callExpression(
j.identifier('bru.runner.setNextRequest'),
args
);
}
},
// Handle pm.execution.setNextRequest(null)
{
pattern: 'pm.execution.setNextRequest',

2
packages/bruno-converters/tests/bruno/bruno-to-postman-translations/execution.test.js
View File

@@ -79,7 +79,7 @@ const status = res.getStatus();
const data = res.getBody();
if (status === 200 && data.hasMore) {
bru.setNextRequest("Fetch Next Page");
bru.runner.setNextRequest("Fetch Next Page");
} else if (status === 429) {
console.log("Rate limited, skipping");
bru.runner.skipRequest();

22
packages/bruno-converters/tests/postman/postman-translations/transpiler-tests/exec-flow.test.js
View File

@@ -5,7 +5,25 @@ describe('Execution Flow Translation', () => {
it('should translate pm.setNextRequest', () => {
const code = 'pm.setNextRequest("Get User Details");';
const translatedCode = translateCode(code);
expect(translatedCode).toBe('bru.setNextRequest("Get User Details");');
expect(translatedCode).toBe('bru.runner.setNextRequest("Get User Details");');
});
it('should translate pm.setNextRequest(null) to bru.runner.stopExecution()', () => {
const code = 'pm.setNextRequest(null);';
const translatedCode = translateCode(code);
expect(translatedCode).toBe('bru.runner.stopExecution();');
});
it('should translate pm.setNextRequest("null") to bru.runner.stopExecution()', () => {
const code = 'pm.setNextRequest("null");';
const translatedCode = translateCode(code);
expect(translatedCode).toBe('bru.runner.stopExecution();');
});
it('should keep pm.setNextRequest(<request name>) as bru.setNextRequest(<request name>) for non-null arguments', () => {
const code = 'pm.setNextRequest("Get User Details");';
const translatedCode = translateCode(code);
expect(translatedCode).toBe('bru.runner.setNextRequest("Get User Details");');
});
it('should translate pm.execution.skipRequest', () => {
@@ -59,6 +77,6 @@ describe('Execution Flow Translation', () => {
expect(translatedCode).toContain('} else if (res.getStatus() === 500) {');
expect(translatedCode).toContain('bru.runner.stopExecution();');
expect(translatedCode).toContain('} else {');
expect(translatedCode).toContain('bru.setNextRequest("Get User Details");');
expect(translatedCode).toContain('bru.runner.setNextRequest("Get User Details");');
});
});

4
packages/bruno-converters/tests/postman/postman-translations/transpiler-tests/postman-references.test.js
View File

@@ -71,9 +71,9 @@ describe('Postman to PM References Conversion', () => {
const translatedCode = translateCode(code);
expect(translatedCode).toContain('if (bru.getEnvVar("isProduction") === "true") {');
expect(translatedCode).toContain('const apiUrl = bru.getEnvVar("prodUrl");');
expect(translatedCode).toContain('bru.setNextRequest("Production Flow");');
expect(translatedCode).toContain('bru.runner.setNextRequest("Production Flow");');
expect(translatedCode).toContain('const apiUrl = bru.getEnvVar("devUrl");');
expect(translatedCode).toContain('bru.setNextRequest("Development Flow");');
expect(translatedCode).toContain('bru.runner.setNextRequest("Development Flow");');
});
// Legacy response handling