v3.4.2

"file does not exist" improving for watchers
Adds additional (initial missing) context to the go generic `os.ErrNotExist` error, in addition to other errors that (possibly) can be returned by `zglob.Glob` Closes #472
2026-06-16 12:21:41 +00:00 · 2021-04-23 18:11:31 -03:00 · 2021-04-23 18:03:49 -03:00 · 2021-04-23 17:45:56 -03:00 · 2021-04-23 17:35:15 -03:00 · 2021-04-20 14:57:23 +02:00
20 changed files with 187 additions and 122 deletions
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -0,0 +1,10 @@
+version: 2
+
+updates:
+  - package-ecosystem: gomod
+    directory: /
+    schedule:
+      interval: weekly
+      day: saturday
+      time: '08:00'
+      timezone: America/Sao_Paulo
--- a/.gitignore
+++ b/.gitignore
@@ -19,8 +19,9 @@ dist/

 .DS_Store

-# intellij idea/goland
+# editors
 .idea/
+.vscode/

 # exuberant ctags
 tags
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -1,6 +1,6 @@
 build:
  binary: task
-  main: cmd/task/task.go
+  main: cmd/task
  goos:
    - windows
    - darwin
@@ -17,6 +17,11 @@ build:
      goarch: 386
  env:
    - CGO_ENABLED=0
+  ldflags:
+    - -s -w # Don't set main.version.
+
+gomod:
+  proxy: true

 archives:
  - name_template: "{{.Binary}}_{{.Os}}_{{.Arch}}"
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,26 @@
 # Changelog

+## v3.4.2 - 2021-04-23
+
+- On watch, report which file failed to read
+  ([#472](https://github.com/go-task/task/pull/472)).
+- Do not try to catch SIGKILL signal, which are not actually possible
+  ([#476](https://github.com/go-task/task/pull/476)).
+- Improve version reporting when building Task from source using Go Modules
+  ([#462](https://github.com/go-task/task/pull/462), [#473](https://github.com/go-task/task/pull/473)).
+
+## v3.4.1 - 2021-04-17
+
+- Improve error reporting when parsing YAML: in some situations where you
+  would just see an generic error, you'll now see the actual error with
+  more detail: the YAML line the failed to parse, for example
+  ([#467](https://github.com/go-task/task/issues/467)).
+- A JSON Schema was published [here](https://json.schemastore.org/taskfile.json)
+  and is automatically being used by some editors like Visual Studio Code
+  ([#135](https://github.com/go-task/task/issues/135)).
+- Print task name before the command in the log output
+  ([#398](https://github.com/go-task/task/pull/398)).
+
 ## v3.3.0 - 2021-03-20

 - Add support for delegating CLI arguments to commands with `--` and a
--- a/cmd/task/task.go
+++ b/cmd/task/task.go
@@ -7,6 +7,7 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
+	"runtime/debug"
 	"strings"
 	"syscall"

@@ -19,7 +20,7 @@ import (
 )

 var (
-	version = "master"
+	version = ""
 )

 const usage = `Usage: task [-ilfwvsd] [--init] [--list] [--force] [--watch] [--verbose] [--silent] [--dir] [--taskfile] [--dry] [--summary] [task...]
@@ -93,7 +94,7 @@ func main() {
 	pflag.Parse()

 	if versionFlag {
-		fmt.Printf("Task version: %s\n", version)
+		fmt.Printf("Task version: %s\n", getVersion())
 		return
 	}

@@ -208,7 +209,7 @@ func getArgs() (tasksAndVars, cliArgs []string) {

 func getSignalContext() context.Context {
 	ch := make(chan os.Signal, 1)
-	signal.Notify(ch, os.Interrupt, os.Kill, syscall.SIGTERM)
+	signal.Notify(ch, os.Interrupt, syscall.SIGTERM)
 	ctx, cancel := context.WithCancel(context.Background())
 	go func() {
 		sig := <-ch
@@ -217,3 +218,21 @@ func getSignalContext() context.Context {
 	}()
 	return ctx
 }
+
+func getVersion() string {
+	if version != "" {
+		return version
+	}
+
+	info, ok := debug.ReadBuildInfo()
+	if !ok || info.Main.Version == "" {
+		return "unknown"
+	}
+
+	version = info.Main.Version
+	if info.Main.Sum != "" {
+		version += fmt.Sprintf(" (%s)", info.Main.Sum)
+	}
+
+	return version
+}
--- a/docs/_sidebar.md
+++ b/docs/_sidebar.md
@@ -2,7 +2,7 @@
 - [Usage](usage.md)
 - [Styleguide](styleguide.md)
 - [Taskfile Versions](taskfile_versions.md)
- [Examples](examples.md)
+- [Community](community.md)
 - [Releasing Task](releasing_task.md)
 - [Donate](donate.md)
- [![GitHub](https://icongram.jgog.in/simple/github.svg?color=808080&size=16)GitHub](https://github.com/go-task/task)
+- [GitHub](https://github.com/go-task/task)
--- a/docs/community.md
+++ b/docs/community.md
@@ -0,0 +1,44 @@
+# Community
+
+Some of the work to improve the Task ecosystem is done by the community, be
+it installation methods or integrations with code editor. I (the author) am
+thankful for everyone that helps me to improve the overall experience.
+
+## Editor Integrations
+
+### JSON Schema
+
+[@KROSF](https://github.com/KROSF) worked on a JSON Schema [into this Gist](https://gist.github.com/KROSF/c5435acf590acd632f71bb720f685895),
+which later was made officially available by [@Crandel](https://github.com/Crandel)
+at [https://json.schemastore.org/taskfile.json](https://json.schemastore.org/taskfile.json).
+Further improvements are possible by opening pull requests changing
+[this file](https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json).
+Some code editors, like Visual Studio Code, make use of Schema Store
+automatically.
+
+### Visual Studio Code extension
+
+Additionally, there's also some work done by
+[@paulvarache](https://github.com/paulvarache) in making an Visual Studio Code
+extension, which has its code [here](https://github.com/paulvarache/vscode-taskfile)
+and is published [here](https://marketplace.visualstudio.com/items?itemName=paulvarache.vscode-taskfile).
+
+## Installation methods
+
+Some installation methods are maintained by third party:
+
+- [GitHub Actions](https://github.com/arduino/actions/tree/master/setup-taskfile)
+  by [@arduino](https://github.com/arduino)
+- [AUR](https://aur.archlinux.org/packages/taskfile-git)
+  by [@kovetskiy](https://github.com/kovetskiy)
+- [Scoop](https://github.com/lukesampson/scoop-extras/blob/master/bucket/task.json)
+
+## More
+
+Also, thanks for all the [code contributors](https://github.com/go-task/task/graphs/contributors),
+[financial contributors](https://opencollective.com/task), all those who
+[reported bugs](https://github.com/go-task/task/issues?q=is%3Aissue) and
+[answered questions](https://github.com/go-task/task/discussions).
+
+If you know something that is missing in this document, please submit a
+pull request.
--- a/docs/examples.md
+++ b/docs/examples.md
@@ -1,7 +0,0 @@
-# Examples
-
-The [go-task/examples][examples] intends to be a collection of Taskfiles for
-various use cases.
-(It still lacks many examples, though. Contributions are welcome).
-
-[examples]: https://github.com/go-task/examples
--- a/docs/index.html
+++ b/docs/index.html
@@ -6,7 +6,7 @@
    <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
    <meta name="description" content="A task runner / simpler Make alternative written in Go">
    <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
-    <link rel="stylesheet" href="//cdn.jsdelivr.net/npm/docsify-themeable/dist/css/theme-simple.css">
+    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsify-themeable@0/dist/css/theme-simple-dark.css">
    <meta name="google-site-verification" content="VGAYkbdmuaciIDGkBe-eAg9yfZg0C6ostgonbGxxOa0" />
    <style>
      #logo {
@@ -20,6 +20,10 @@
      .app-name-link img {
        width: 125px;
      }
+      :root {
+        --base-font-size: 14px;
+        --theme-color: #29beb0;
+      }
    </style>
  </head>
  <body>
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -68,12 +68,12 @@ The `task_checksums.txt` file contains the SHA-256 checksum for each file.

 #### **Install Script**

-We also have a [install script][installscript], which is very useful on
-scenarios like CIs. Many thanks to [GoDownloader][godownloader] for allowing
-easily generating this script.
+We also have an [install script][installscript] which is very useful in
+scenarios like CI. Many thanks to [GoDownloader][godownloader] for enabling the
+easy generation of this script.

 ```bash
-# For Default Installion to ./bin with debug logging
+# For Default Installation to ./bin with debug logging
 sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d

 # For Installation To /usr/local/bin for userwide access with debug logging
@@ -107,29 +107,27 @@ This installation method is community owned.

 First, make sure you have [Go][go] properly installed and setup.

-You can easily install it globally by running:
+You can easily install the latest release globally by running:

 ```bash
-go get -u github.com/go-task/task/v3/cmd/task
+go install github.com/go-task/task/v3/cmd/task@latest
 ```

 Or you can install into another directory:

 ```bash
-git clone https://github.com/go-task/task
-cd task
+env GOBIN=/bin go install github.com/go-task/task/v3/cmd/task@latest
+```

-# Compiling binary to $GOPATH/bin
-go install -v ./cmd/task
+If using Go 1.15 or earlier, instead use:

-# Compiling it to another location.
-# Use -o ./task.exe on Windows.
-go build -v -o ./task ./cmd/task
+```bash
+env GO111MODULE=on go get -u github.com/go-task/task/v3/cmd/task@latest
 ```

 > For CI environments we recommend using the [Install Script](#get-the-binary)
 > instead, which is faster and more stable, since it'll just download the latest
-> released binary, instead of compiling the edge (master branch) version.
+> released binary.

 <!-- tabs:end -->

--- a/docs/releasing_task.md
+++ b/docs/releasing_task.md
@@ -36,4 +36,4 @@ If you think its Task version is outdated, open an issue to let us know.
 [gotaskrb]: https://github.com/go-task/homebrew-tap/blob/master/Formula/go-task.rb
 [snappackage]: https://github.com/go-task/snap
 [snapcraftyaml]: https://github.com/go-task/snap/blob/master/snap/snapcraft.yaml#L2
-[snapcraftdashboard]: https://dashboard.snapcraft.io/
+[snapcraftdashboard]: https://snapcraft.io/task/releases
--- a/go.mod
+++ b/go.mod
@@ -1,14 +1,13 @@
 module github.com/go-task/task/v3

 require (
-	github.com/fatih/color v1.7.0
+	github.com/fatih/color v1.10.0
 	github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0
 	github.com/joho/godotenv v1.3.0
-	github.com/mattn/go-colorable v0.1.2 // indirect
-	github.com/mattn/go-zglob v0.0.1
-	github.com/radovskyb/watcher v1.0.5
+	github.com/mattn/go-zglob v0.0.3
+	github.com/radovskyb/watcher v1.0.7
 	github.com/spf13/pflag v1.0.5
-	github.com/stretchr/testify v1.5.1
+	github.com/stretchr/testify v1.7.0
 	golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9
 	gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
 	mvdan.cc/sh/v3 v3.2.4
--- a/go.sum
+++ b/go.sum
@@ -6,8 +6,8 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys=
-github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
+github.com/fatih/color v1.10.0 h1:s36xzo75JdqLaaWoiEHk767eHiwo0598uUxyfiPkDsg=
+github.com/fatih/color v1.10.0/go.mod h1:ELkj/draVOlAH/xkhN6mQ50Qd0MPOk5AAr3maGEBuJM=
 github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 h1:p104kn46Q8WdvHunIJ9dAyjPVtrBPhSr3KT2yUst43I=
 github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE=
 github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
@@ -19,29 +19,31 @@ github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfn
 github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
-github.com/mattn/go-colorable v0.1.2 h1:/bC9yWikZXAL9uJdulbSfyVNIR3n3trXl+v8+1sx8mU=
-github.com/mattn/go-colorable v0.1.2/go.mod h1:U0ppj6V5qS13XJ6of8GYAs25YV2eR4EVcfRqFIhoBtE=
-github.com/mattn/go-isatty v0.0.8 h1:HLtExJ+uU2HOZ+wI0Tt5DtUDrx8yhUqDcp7fYERX4CE=
-github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s=
-github.com/mattn/go-zglob v0.0.1 h1:xsEx/XUoVlI6yXjqBK062zYhRTZltCNmYPx6v+8DNaY=
-github.com/mattn/go-zglob v0.0.1/go.mod h1:9fxibJccNxU2cnpIKLRRFA7zX7qhkJIQWBb449FYHOo=
+github.com/mattn/go-colorable v0.1.8 h1:c1ghPdyEDarC70ftn0y+A/Ee++9zz8ljHG1b13eJ0s8=
+github.com/mattn/go-colorable v0.1.8/go.mod h1:u6P/XSegPjTcexA+o6vUJrdnUu04hMope9wVRipJSqc=
+github.com/mattn/go-isatty v0.0.12 h1:wuysRhFDzyxgEmMf5xjvJ2M9dZoWAXNNr5LSBS7uHXY=
+github.com/mattn/go-isatty v0.0.12/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU=
+github.com/mattn/go-zglob v0.0.3 h1:6Ry4EYsScDyt5di4OI6xw1bYhOqfE5S33Z1OPy+d+To=
+github.com/mattn/go-zglob v0.0.3/go.mod h1:9fxibJccNxU2cnpIKLRRFA7zX7qhkJIQWBb449FYHOo=
 github.com/pkg/diff v0.0.0-20200914180035-5b29258ca4f7/go.mod h1:zO8QMzTeZd5cpnIkz/Gn6iK0jDfGicM1nynOkkPIl28=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/radovskyb/watcher v1.0.5 h1:wqt7gb+HjGacvFoLTKeT44C+XVPxu7bvHvKT1IvZ7rw=
-github.com/radovskyb/watcher v1.0.5/go.mod h1:78okwvY5wPdzcb1UYnip1pvrZNIVEIh/Cm+ZuvsUYIg=
+github.com/radovskyb/watcher v1.0.7 h1:AYePLih6dpmS32vlHfhCeli8127LzkIgwJGcwwe8tUE=
+github.com/radovskyb/watcher v1.0.7/go.mod h1:78okwvY5wPdzcb1UYnip1pvrZNIVEIh/Cm+ZuvsUYIg=
 github.com/rogpeppe/go-internal v1.6.2/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTEfhy4qGm1nDQc=
 github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
 github.com/spf13/pflag v1.0.5 h1:iy+VFUOCP1a+8yFto/drg2CJ5u0yRoB7fZw3DKv/JXA=
 github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
-github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4=
 github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
+github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
+github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9 h1:SQFwaSi55rU7vdNs9Yr0Z324VNlrF+0wMqRXT4St8ck=
 golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
-golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20201029080932-201ba4db2418 h1:HlFl4V6pEMziuLXyRkm5BIYq1y1GAbb02pRlWvI54OM=
 golang.org/x/sys v0.0.0-20201029080932-201ba4db2418/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/term v0.0.0-20191110171634-ad39bd3f0407 h1:5zh5atpUEdIc478E/ebrIaHLKcfVvG6dL/fGv7BcMoM=
@@ -50,7 +52,6 @@ gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 h1:qIbj1fsPNlZgppZ+VLlY7N33q108Sa+fhmuc+sWQYwY=
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/errgo.v2 v2.1.0/go.mod h1:hNsd1EY+bozCKY1Ytp96fpM3vjJbqLJn88ws8XvfDNI=
-gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
--- a/task.go
+++ b/task.go
@@ -366,7 +366,7 @@ func (e *Executor) runCommand(ctx context.Context, t *taskfile.Task, call taskfi
 		return nil
 	case cmd.Cmd != "":
 		if e.Verbose || (!cmd.Silent && !t.Silent && !e.Taskfile.Silent && !e.Silent) {
-			e.Logger.Errf(logger.Green, "task: %s", cmd.Cmd)
+			e.Logger.Errf(logger.Green, "task: [%s] %s", t.Name(), cmd.Cmd)
 		}

 		if e.Dry {
@@ -397,7 +397,7 @@ func (e *Executor) runCommand(ctx context.Context, t *taskfile.Task, call taskfi
 			Stderr:  stdErr,
 		})
 		if execext.IsExitError(err) && cmd.IgnoreError {
-			e.Logger.VerboseErrf(logger.Yellow, "task: command error ignored: %v", err)
+			e.Logger.VerboseErrf(logger.Yellow, "task: [%s] command error ignored: %v", t.Name(), err)
 			return nil
 		}
 		return err
--- a/task_test.go
+++ b/task_test.go
@@ -626,7 +626,7 @@ func TestDry(t *testing.T) {
 	assert.NoError(t, e.Setup())
 	assert.NoError(t, e.Run(context.Background(), taskfile.Call{Task: "build"}))

-	assert.Equal(t, "task: touch file.txt", strings.TrimSpace(buff.String()))
+	assert.Equal(t, "task: [build] touch file.txt", strings.TrimSpace(buff.String()))
 	if _, err := os.Stat(file); err == nil {
 		t.Errorf("File should not exist %s", file)
 	}
--- a/taskfile/cmd.go
+++ b/taskfile/cmd.go
@@ -1,7 +1,6 @@
 package taskfile

 import (
-	"errors"
 	"strings"
 )

@@ -20,13 +19,6 @@ type Dep struct {
 	Vars *Vars
 }

-var (
-	// ErrCantUnmarshalCmd is returned for invalid command YAML
-	ErrCantUnmarshalCmd = errors.New("task: can't unmarshal cmd value")
-	// ErrCantUnmarshalDep is returned for invalid dependency YAML
-	ErrCantUnmarshalDep = errors.New("task: can't unmarshal dep value")
-)
-
 // UnmarshalYAML implements yaml.Unmarshaler interface
 func (c *Cmd) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	var cmd string
@@ -53,12 +45,12 @@ func (c *Cmd) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		Task string
 		Vars *Vars
 	}
-	if err := unmarshal(&taskCall); err == nil {
-		c.Task = taskCall.Task
-		c.Vars = taskCall.Vars
-		return nil
+	if err := unmarshal(&taskCall); err != nil {
+		return err
 	}
-	return ErrCantUnmarshalCmd
+	c.Task = taskCall.Task
+	c.Vars = taskCall.Vars
+	return nil
 }

 // UnmarshalYAML implements yaml.Unmarshaler interface
@@ -72,10 +64,10 @@ func (d *Dep) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		Task string
 		Vars *Vars
 	}
-	if err := unmarshal(&taskCall); err == nil {
-		d.Task = taskCall.Task
-		d.Vars = taskCall.Vars
-		return nil
+	if err := unmarshal(&taskCall); err != nil {
+		return err
 	}
-	return ErrCantUnmarshalDep
+	d.Task = taskCall.Task
+	d.Vars = taskCall.Vars
+	return nil
 }
--- a/taskfile/included_taskfile.go
+++ b/taskfile/included_taskfile.go
@@ -6,11 +6,6 @@ import (
 	"gopkg.in/yaml.v3"
 )

-var (
-	// ErrCantUnmarshalIncludedTaskfile is returned for invalid var YAML.
-	ErrCantUnmarshalIncludedTaskfile = errors.New("task: can't unmarshal included value")
-)
-
 // IncludedTaskfile represents information about included tasksfile
 type IncludedTaskfile struct {
 	Taskfile       string
@@ -98,12 +93,11 @@ func (it *IncludedTaskfile) UnmarshalYAML(unmarshal func(interface{}) error) err
 		Taskfile string
 		Dir      string
 	}
-	if err := unmarshal(&includedTaskfile); err == nil {
-		it.Dir = includedTaskfile.Dir
-		it.Taskfile = includedTaskfile.Taskfile
-		it.AdvancedImport = true
-		return nil
+	if err := unmarshal(&includedTaskfile); err != nil {
+		return err
 	}
-
-	return ErrCantUnmarshalIncludedTaskfile
+	it.Dir = includedTaskfile.Dir
+	it.Taskfile = includedTaskfile.Taskfile
+	it.AdvancedImport = true
+	return nil
 }
--- a/taskfile/task.go
+++ b/taskfile/task.go
@@ -1,9 +1,5 @@
 package taskfile

-import (
-	"errors"
-)
-
 // Tasks represents a group of tasks
 type Tasks map[string]*Task

@@ -28,11 +24,6 @@ type Task struct {
 	IgnoreError   bool
 }

-var (
-	// ErrCantUnmarshalTask is returned for invalid task YAML
-	ErrCantUnmarshalTask = errors.New("task: can't unmarshal task value")
-)
-
 func (t *Task) Name() string {
 	if t.Label != "" {
 		return t.Label
@@ -71,26 +62,24 @@ func (t *Task) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		Prefix        string
 		IgnoreError   bool `yaml:"ignore_error"`
 	}
-	if err := unmarshal(&task); err == nil {
-		t.Cmds = task.Cmds
-		t.Deps = task.Deps
-		t.Label = task.Label
-		t.Desc = task.Desc
-		t.Summary = task.Summary
-		t.Sources = task.Sources
-		t.Generates = task.Generates
-		t.Status = task.Status
-		t.Preconditions = task.Preconditions
-		t.Dir = task.Dir
-		t.Vars = task.Vars
-		t.Env = task.Env
-		t.Silent = task.Silent
-		t.Method = task.Method
-		t.Prefix = task.Prefix
-		t.IgnoreError = task.IgnoreError
-
-		return nil
+	if err := unmarshal(&task); err != nil {
+		return err
 	}
-
-	return ErrCantUnmarshalTask
+	t.Cmds = task.Cmds
+	t.Deps = task.Deps
+	t.Label = task.Label
+	t.Desc = task.Desc
+	t.Summary = task.Summary
+	t.Sources = task.Sources
+	t.Generates = task.Generates
+	t.Status = task.Status
+	t.Preconditions = task.Preconditions
+	t.Dir = task.Dir
+	t.Vars = task.Vars
+	t.Env = task.Env
+	t.Silent = task.Silent
+	t.Method = task.Method
+	t.Prefix = task.Prefix
+	t.IgnoreError = task.IgnoreError
+	return nil
 }
--- a/taskfile/var.go
+++ b/taskfile/var.go
@@ -7,11 +7,6 @@ import (
 	"gopkg.in/yaml.v3"
 )

-var (
-	// ErrCantUnmarshalVar is returned for invalid var YAML.
-	ErrCantUnmarshalVar = errors.New("task: can't unmarshal var value")
-)
-
 // Vars is a string[string] variables map.
 type Vars struct {
 	Keys    []string
@@ -124,10 +119,9 @@ func (v *Var) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	var sh struct {
 		Sh string
 	}
-	if err := unmarshal(&sh); err == nil {
-		v.Sh = sh.Sh
-		return nil
+	if err := unmarshal(&sh); err != nil {
+		return err
 	}
-
-	return ErrCantUnmarshalVar
+	v.Sh = sh.Sh
+	return nil
 }
--- a/watch.go
+++ b/watch.go
@@ -2,6 +2,7 @@ package task

 import (
 	"context"
+	"fmt"
 	"os"
 	"os/signal"
 	"path/filepath"
@@ -129,7 +130,7 @@ func (e *Executor) registerWatchedFiles(w *watcher.Watcher, calls ...taskfile.Ca
 		for _, s := range task.Sources {
 			files, err := zglob.Glob(s)
 			if err != nil {
-				return err
+				return fmt.Errorf("task: %s: %w", s, err)
 			}
 			for _, f := range files {
 				absFile, err := filepath.Abs(f)
Author	SHA1	Message	Date
Andrey Nering	f8545d4c61	v3.4.2	2021-04-23 18:11:31 -03:00
Oleg Butuzov	9b42ef5d46	"file does not exist" improving for watchers Adds additional (initial missing) context to the go generic `os.ErrNotExist` error, in addition to other errors that (possibly) can be returned by `zglob.Glob` Closes #472	2021-04-23 18:03:49 -03:00
Andrey Nering	05ddfc0495	Merge pull request #476 from Pix4D/fix-os-kill signals: do not try to catch uncatchable signals	2021-04-23 17:45:56 -03:00
Andrey Nering	53b2cebb66	Updated the version output to use Go module build information if avalable. Enabled GoReleaser module proxying for verifiable builds. Co-authored-by: Jamie Edge <JamieEdge@users.noreply.github.com> Co-authored-by: Carlos Alexandro Becker <caarlos0@gmail.com>	2021-04-23 17:35:15 -03:00
Marco Molteni	837fb71a24	signals: do not try to catch uncatchable signals os.Kill is SIGKILL (kill -9), cannot be intercepted. (see https://github.com/golang/go/issues/13080)	2021-04-20 14:57:23 +02:00
Marco Molteni	2e13cf5f74	gitignore more editors	2021-04-20 14:54:24 +02:00
Andrey Nering	0ae1681d9c	CHANGELOG: Fix typos	2021-04-17 17:57:08 -03:00
Andrey Nering	ebb66ba8fb	v3.4.1	2021-04-17 17:48:36 -03:00
Andrey Nering	e79354a039	Revert "Updated the version output to use Go module build information if available. Enabled GoReleaser module proxying for verifiable builds." This reverts commit `2a3f049336`.	2021-04-17 17:47:24 -03:00
Andrey Nering	a57beb1de4	Website: Remove GitHub logo The website that hosted the SVG file is offline for a while.	2021-04-17 17:34:00 -03:00
Andrey Nering	1648c44ee2	Website: Use dark theme	2021-04-17 17:34:00 -03:00
Andrey Nering	efe47a149e	Website: Remove "Examples" page	2021-04-17 17:33:52 -03:00
Andrey Nering	2d66a2f0f3	Improve YAML parse error reporting Fixes #467	2021-04-17 17:12:39 -03:00
Andrey Nering	43a1f1314e	Website: Add a "Community" page	2021-04-17 11:59:24 -03:00
Andrey Nering	4f4b282d7c	Merge pull request #471 from go-task/dependabot/go_modules/github.com/stretchr/testify-1.7.0 Bump github.com/stretchr/testify from 1.5.1 to 1.7.0	2021-04-17 10:53:03 -03:00
dependabot[bot]	d3d4da18e5	Bump github.com/stretchr/testify from 1.5.1 to 1.7.0 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.5.1 to 1.7.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.5.1...v1.7.0) Signed-off-by: dependabot[bot] <support@github.com>	2021-04-17 13:51:37 +00:00
Andrey Nering	b8da583986	Merge pull request #470 from go-task/dependabot/go_modules/github.com/fatih/color-1.10.0 Bump github.com/fatih/color from 1.7.0 to 1.10.0	2021-04-17 10:51:01 -03:00
Andrey Nering	73f6b42715	Merge pull request #469 from go-task/dependabot/go_modules/github.com/radovskyb/watcher-1.0.7 Bump github.com/radovskyb/watcher from 1.0.5 to 1.0.7	2021-04-17 10:50:21 -03:00
dependabot[bot]	0e2a4efdaa	Bump github.com/radovskyb/watcher from 1.0.5 to 1.0.7 Bumps [github.com/radovskyb/watcher](https://github.com/radovskyb/watcher) from 1.0.5 to 1.0.7. - [Release notes](https://github.com/radovskyb/watcher/releases) - [Commits](https://github.com/radovskyb/watcher/compare/1.0.5...v1.0.7) Signed-off-by: dependabot[bot] <support@github.com>	2021-04-17 13:47:39 +00:00
dependabot[bot]	6798e16aaf	Bump github.com/fatih/color from 1.7.0 to 1.10.0 Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.7.0 to 1.10.0. - [Release notes](https://github.com/fatih/color/releases) - [Commits](https://github.com/fatih/color/compare/v1.7.0...v1.10.0) Signed-off-by: dependabot[bot] <support@github.com>	2021-04-17 13:47:38 +00:00
Andrey Nering	c9cc64ecfc	Merge pull request #468 from go-task/dependabot/go_modules/github.com/mattn/go-zglob-0.0.3 Bump github.com/mattn/go-zglob from 0.0.1 to 0.0.3	2021-04-17 10:46:42 -03:00
dependabot[bot]	761f9045ac	Bump github.com/mattn/go-zglob from 0.0.1 to 0.0.3 Bumps [github.com/mattn/go-zglob](https://github.com/mattn/go-zglob) from 0.0.1 to 0.0.3. - [Release notes](https://github.com/mattn/go-zglob/releases) - [Commits](https://github.com/mattn/go-zglob/compare/v0.0.1...v0.0.3) Signed-off-by: dependabot[bot] <support@github.com>	2021-04-17 13:43:00 +00:00
Andrey Nering	dfae979287	Add .github/dependabot.yml	2021-04-17 10:42:18 -03:00
George Pollard	fe917affd2	Include task name in log output	2021-04-04 16:16:22 -03:00
Andrey Nering	d44207dd7f	Merge pull request #463 from JamieEdge/update-install-docs Update Go modules installation documentation for Go 1.16	2021-04-04 15:48:19 -03:00
Andrey Nering	ec8b1403bd	Use early return and add CHANGELOG for #462	2021-04-04 15:40:34 -03:00
Jamie Edge	6f3d108c1e	Updated the install script documentation.	2021-04-04 17:31:41 +01:00
Jamie Edge	c34ee9c1f9	Updated the Go modules installation documentation for Go 1.16.	2021-04-04 17:30:42 +01:00
Jamie Edge	2a3f049336	Updated the version output to use Go module build information if available. Enabled GoReleaser module proxying for verifiable builds.	2021-04-04 12:57:58 +01:00
Andrey Nering	0c91011e88	Merge pull request #460 from patrick-mota/patch-1 Fix typo default installation	2021-03-28 11:10:38 -03:00
Andrey Nering	8bcd8719aa	Docs: Add GO111MODULE=on to `go get` command	2021-03-28 10:45:36 -03:00
Ganon	29a8af509b	Fix typo default installation	2021-03-26 13:19:45 +01:00
Andrey Nering	d3cd9f17f9	Documentation: Update link	2021-03-20 13:30:38 -03:00