mirror of
https://github.com/usebruno/bruno.git
synced 2026-07-08 14:35:03 +00:00
* feat: add description column to various tables and enhance UI interactions - Introduced a description column in Headers, VarsTable, and other components to allow multi-line descriptions. - Added toggle buttons to show/hide the description column in relevant tables. - Updated EditableTable component to support dynamic row addition with customizable labels. - Enhanced UI for better user experience with consistent button styles and spacing adjustments. * chore: resize fix handles * fix: restrict column check for last index * refactor: remove unwanted style and fix bottom padding of the last child in the table row * tests: improve testability and fix impacted locators * tests: fix locators for value fields * fix: improve newline handling in description prefix * fix: ts changes * chore: remove redundant code and fix description roundtrip * chore: remove redundant check * tests(bru-lang): tests for description and annotation * test: improve locators and tests * tests: descriptions * chore: re-add description setup * fix: re-add description cols * chore: fix the double click reset * fix: account for hidden sidebar in request pane width calculation * refactor: ui/ux fixes for data type toggle * chore: inline common deps into bruno-lang and bruno-schema * chore: tests * chore: fix ux for descriptions * fix: layout for environment vars table * fix: ensure correct row selection for multipart file upload in tests * feat: enhance UID assignment for request headers and variables in collections * chore: simplify * chore: update pkg * chore: abstract the e2e utils * chore: fix exports * tests: fix locators for datatype vars * fix: ux issue with secrets in environment table * tests: update locators for collection headers and vars descriptions * tests: update locators to use data attributes for datatype selectors * chore: update default css width for actions column * chore: remove tooltip for string type warnings * fix: reduce name widths * refactor: update annotation serialization to use single-quote delimiters for descriptions * refactor(tests): simplify description formatting in jsonToEnv tests * feat: add multiline description escaping and unescaping functions with tests * refactor: clean up imports and improve multiline text block handling * refactor: update locators to use new test IDs for environment variable editors * refactor: streamline header input handling and improve environment variable row access * refactor: update e2e-test job to support self-hosted runners * refactor: update E2E test runner configuration to include e2e and macOS environments --------- Co-authored-by: Pragadesh-45 <temporaryg7904@gmail.com>
99 lines
3.8 KiB
TypeScript
99 lines
3.8 KiB
TypeScript
import { test, expect } from '../../../playwright';
|
|
import { closeAllCollections, createCollection, createRequest, openCollection, openRequest, saveRequest, selectRequestPaneTab } from '../../utils/page';
|
|
import { getTableCell } from '../../utils/page/locators';
|
|
|
|
const saveShortcut = process.platform === 'darwin' ? 'Meta+s' : 'Control+s';
|
|
|
|
test.describe.serial('Header Validation', () => {
|
|
test.afterAll(async ({ page }) => {
|
|
await closeAllCollections(page);
|
|
});
|
|
|
|
test.beforeAll(async ({ page, createTmpDir }) => {
|
|
await test.step('Create collection and request', async () => {
|
|
await createCollection(page, 'header-validation', await createTmpDir('header-validation'));
|
|
await createRequest(page, 'test-headers', '', {
|
|
url: 'https://httpbin.org/get',
|
|
inFolder: false
|
|
});
|
|
});
|
|
|
|
await test.step('Open the request', async () => {
|
|
await openCollection(page, 'header-validation');
|
|
await openRequest(page, 'header-validation', 'test-headers', { persist: true });
|
|
});
|
|
});
|
|
|
|
test('should show error icon when header name contains spaces', async ({ page, createTmpDir }) => {
|
|
await test.step('Navigate to Headers tab', async () => {
|
|
await selectRequestPaneTab(page, 'Headers');
|
|
});
|
|
|
|
await test.step('Enter header name with space and verify error icon', async () => {
|
|
const headerRow = page.locator('table tbody tr').first();
|
|
const nameCell = getTableCell(headerRow, 0);
|
|
|
|
// Click on the CodeMirror editor and type a header name with space
|
|
await nameCell.locator('.CodeMirror').click();
|
|
await nameCell.locator('textarea').fill('invalid header');
|
|
|
|
// Verify the error icon is visible
|
|
const errorIcon = headerRow.locator('.text-red-600');
|
|
await expect(errorIcon).toBeVisible();
|
|
|
|
// Hover over the error icon to show the tooltip
|
|
await errorIcon.hover();
|
|
|
|
// Verify the tooltip message
|
|
const tooltip = page.locator('.tooltip-mod');
|
|
await expect(tooltip).toContainText('Header name cannot contain spaces or newlines');
|
|
});
|
|
|
|
await test.step('Enter valid header name and verify no error icon', async () => {
|
|
const headerRow = page.locator('table tbody tr').first();
|
|
const nameCell = getTableCell(headerRow, 0);
|
|
|
|
// Clear and enter a valid header name.
|
|
await nameCell.locator('.CodeMirror').click();
|
|
await page.keyboard.press(process.platform === 'darwin' ? 'Meta+A' : 'Control+A');
|
|
await page.keyboard.insertText('Valid-Header');
|
|
|
|
// Verify the error icon is not visible
|
|
const errorIcon = headerRow.locator('.text-red-600');
|
|
|
|
// wait for formik to revalidate
|
|
await headerRow.click();
|
|
await expect(errorIcon).not.toBeVisible({});
|
|
});
|
|
});
|
|
|
|
test('should show error icon when header value contains newlines', async ({ page }) => {
|
|
await test.step('Navigate to Headers tab', async () => {
|
|
await selectRequestPaneTab(page, 'Headers');
|
|
});
|
|
|
|
await test.step('Enter header value with newline and verify error icon', async () => {
|
|
const headerRow = page.locator('table tbody tr').first();
|
|
const valueCell = getTableCell(headerRow, 1);
|
|
|
|
// Click on the value CodeMirror editor and type a value with newline
|
|
await valueCell.locator('.CodeMirror').click();
|
|
await valueCell.locator('textarea').fill('header\nValue');
|
|
|
|
// Verify the error icon is visible
|
|
const errorIcon = headerRow.locator('.text-red-600');
|
|
await expect(errorIcon).toBeVisible();
|
|
|
|
// Hover over the error icon to show the tooltip
|
|
await errorIcon.hover();
|
|
|
|
// Verify the tooltip message
|
|
const tooltip = page.locator('.tooltip-mod');
|
|
await expect(tooltip).toContainText('Header value cannot contain newlines');
|
|
|
|
// Save the request
|
|
await page.keyboard.press(saveShortcut);
|
|
});
|
|
});
|
|
});
|