rayan/bruno
1
0
Fork 0
mirror of https://github.com/usebruno/bruno.git synced 2026-06-11 09:51:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(schema): support all Unicode letters in tag validation (#7311)

Browse Source 
* allow international characters in tag regex for UI and schema
  validation
* update validation messages to match this

Co-authored-by: Miro Metsänheimo <miro.metsanheimo@cgi.com>
This commit is contained in:
Miro Metsänheimo
2026-02-26 18:26:02 +02:00
committed by GitHub
parent da1d7e51d2
commit fcfb7d409c
3 changed files with 38 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/bruno-app/src/components/TagList/index.js
View File

@@ -7,7 +7,7 @@ import { useTheme } from 'providers/Theme/index';
const TagList = ({ tagsHintList = [], handleAddTag, tags, handleRemoveTag, onSave, handleValidation, collectionFormat }) => {
const { displayedTheme } = useTheme();
const isBruFormat = collectionFormat === 'bru';
const tagNameRegex = isBruFormat ? /^[\w-]+$/ : /^[\w-][\w\s-]*[\w-]$|^[\w-]+$/;
const tagNameRegex = isBruFormat ? /^[\p{L}\p{N}_-]+$/u : /^[\p{L}\p{N}_-](?:[\p{L}\p{N}_\s-]*[\p{L}\p{N}_-])?$/u;
const [text, setText] = useState('');
const [error, setError] = useState('');
@@ -22,8 +22,8 @@ const TagList = ({ tagsHintList = [], handleAddTag, tags, handleRemoveTag, onSav
}
if (!tagNameRegex.test(text)) {
setError(isBruFormat
? 'Tags in BRU format must only contain alpha-numeric characters, "-", "_".'
: 'Tags must only contain alpha-numeric characters, spaces, "-", "_"'
? 'Tags in BRU format must only contain letters, numbers, "-", "_".'
: 'Tags must only contain letters, numbers, spaces, "-", "_"'
);
return;
}

2
packages/bruno-schema/src/collections/index.js
View File

@@ -545,7 +545,7 @@ const itemSchema = Yup.object({
type: Yup.string().oneOf(['http-request', 'graphql-request', 'folder', 'js', 'grpc-request', 'ws-request']).required('type is required'),
seq: Yup.number().min(1),
name: Yup.string().min(1, 'name must be at least 1 character').required('name is required'),
tags: Yup.array().of(Yup.string().matches(/^[\w-][\w\s-]*[\w-]$|^[\w-]+$/, 'tag must contain only alphanumeric characters, spaces, hyphens, or underscores')),
tags: Yup.array().of(Yup.string().matches(/^[\p{L}\p{N}_-](?:[\p{L}\p{N}_\s-]*[\p{L}\p{N}_-])?$/u, 'tag must contain only letters, numbers, spaces, hyphens, or underscores')),
request: Yup.mixed().when('type', {
is: (type) => type === 'grpc-request',
then: grpcRequestSchema.required('request is required when item-type is grpc-request'),

34
packages/bruno-schema/src/collections/itemSchema.spec.js
View File

@@ -15,6 +15,40 @@ describe('Item Schema Validation', () => {
expect(isValid).toBeTruthy();
});
it('item schema must validate tag regex rules', async () => {
const validItem = {
uid: uuid(),
name: 'A Folder',
type: 'folder',
tags: ['tag_1', 'Äiti-123 test']
};
const isValid = await itemSchema.validate(validItem);
expect(isValid).toBeTruthy();
let invalidItem = {
uid: uuid(),
name: 'A Folder',
type: 'folder',
tags: [' invalid-tag']
};
await expect(itemSchema.validate(invalidItem)).rejects.toThrow(
'tag must contain only letters, numbers, spaces, hyphens, or underscores'
);
invalidItem = {
uid: uuid(),
name: 'A Folder',
type: 'folder',
tags: ['tag🔥name']
};
await expect(itemSchema.validate(invalidItem)).rejects.toThrow(
'tag must contain only letters, numbers, spaces, hyphens, or underscores'
);
});
it('item schema must throw an error if name is missing', async () => {
const item = {
uid: uuid(),