rayan/bruno
1
0
Fork 0
mirror of https://github.com/usebruno/bruno.git synced 2026-06-30 16:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable editing runtime variable if same as collection (#6835)

Browse Source 
Co-authored-by: shubh-bruno <shubh-bruno@shubh-brunos-MacBook-Air.local>
This commit is contained in:
shubh-bruno
2026-01-27 22:08:41 +05:30
committed by GitHub
parent 21673f46de
commit af6908e9c0
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
View File

@@ -1870,7 +1870,7 @@ export const updateVariableInScope = (variableName, newValue, scopeInfo, collect
return reject(new Error('Process environment variables are read-only'));
}
if (type === 'runtime') {
if (type === 'runtime' || (collection && collection.runtimeVariables && collection.runtimeVariables[variableName])) {
toast.error('Runtime variables are set by scripts and cannot be edited');
return reject(new Error('Runtime variables are read-only'));
}

10
packages/bruno-app/src/utils/codemirror/brunoVarInfo.js
View File

@@ -252,8 +252,10 @@ export const renderVarInfo = (token, options) => {
}
}
// Check if a runtime variable exists with the same name (even if scope is detected as collection/folder/environment)
const hasRuntimeVariable = collection && collection.runtimeVariables && collection.runtimeVariables[variableName];
// Check if variable is read-only (process.env, runtime, dynamic/faker, oauth2, and undefined variables cannot be edited)
const isReadOnly = scopeInfo.type === 'process.env' || scopeInfo.type === 'runtime' || scopeInfo.type === 'dynamic' || scopeInfo.type === 'oauth2' || scopeInfo.type === 'undefined';
const isReadOnly = scopeInfo.type === 'process.env' || scopeInfo.type === 'runtime' || scopeInfo.type === 'dynamic' || scopeInfo.type === 'oauth2' || scopeInfo.type === 'undefined' || hasRuntimeVariable;
// Get raw value from scope
const rawValue = scopeInfo.value || '';
@@ -279,8 +281,10 @@ export const renderVarInfo = (token, options) => {
const scopeBadge = document.createElement('span');
scopeBadge.className = 'var-scope-badge';
// Check if a runtime variable exists - if so, show Runtime scope (even if detected as collection/folder/environment)
const displayScopeType = hasRuntimeVariable ? 'runtime' : (scopeInfo ? scopeInfo.type : 'Unknown');
// Show scope label with indication if it's a new variable
const scopeLabel = scopeInfo ? getScopeLabel(scopeInfo.type) : 'Unknown';
const scopeLabel = getScopeLabel(displayScopeType);
const isNewVariable = scopeInfo && scopeInfo.data && scopeInfo.data.variable === null;
scopeBadge.textContent = isNewVariable ? `${scopeLabel}` : scopeLabel;
@@ -578,7 +582,7 @@ export const renderVarInfo = (token, options) => {
readOnlyNote.className = 'var-readonly-note';
readOnlyNote.textContent = 'read-only';
into.appendChild(readOnlyNote);
} else if (scopeInfo.type === 'runtime') {
} else if (scopeInfo.type === 'runtime' || hasRuntimeVariable) {
const readOnlyNote = document.createElement('div');
readOnlyNote.className = 'var-readonly-note';
readOnlyNote.textContent = 'Set by scripts (read-only)';