first commit

test/integration/typeof-window-replace/app/node_modules/comps/index.js

@@ -0,0 +1,5 @@
+const react = require('react')
+
+module.exports = function() {
+  return react.createElement('p', null, 'MyComp:', typeof window)
+}

test/integration/typeof-window-replace/app/node_modules/comps/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "comps",
+  "version": "1.0.0",
+  "main": "index.js",
+  "license": "MIT"
+}

test/integration/typeof-window-replace/app/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "app",
+  "version": "1.0.0",
+  "main": "index.js",
+  "license": "MIT"
+}

test/integration/typeof-window-replace/app/pages/index.js

@@ -0,0 +1,12 @@
+import MyComp from 'comps'
+
+const Page = () => (
+  <>
+    <p>Hello {typeof window}</p>
+    <MyComp />
+  </>
+)
+
+Page.getInitialProps = () => ({})
+
+export default Page

test/integration/typeof-window-replace/test/index.test.ts

@@ -0,0 +1,85 @@
+/* eslint-env jest */
+
+import fs from 'fs-extra'
+import path from 'path'
+import { nextBuild } from 'next-test-utils'
+
+const appDir = path.join(__dirname, '../app')
+let buildManifest
+
+describe('typeof window replace', () => {
+  ;(process.env.TURBOPACK_DEV ? describe.skip : describe)(
+    'production mode',
+    () => {
+      beforeAll(async () => {
+        await nextBuild(appDir)
+        buildManifest = require(path.join(appDir, '.next/build-manifest.json'))
+      })
+
+      it('Replaces `typeof window` with object for client code', async () => {
+        let allContent = ''
+        const files = buildManifest.pages['/'].filter((item) =>
+          item.endsWith('.js')
+        )
+        for (const file of files) {
+          const content = await fs.readFile(
+            path.join(appDir, '.next', file),
+            'utf8'
+          )
+          allContent += content
+        }
+        expect(allContent).toMatch(/Hello.*?,.*?\n?.*?("|')object("|')/)
+      })
+
+      it('Replaces `typeof window` with undefined for server code', async () => {
+        let allContent = ''
+        const chunksFilesDir = path.join(appDir, '.next', 'server', 'chunks')
+        const allFilesInDotNextServerChunks = await fs
+          .readdirSync(chunksFilesDir, {
+            recursive: true,
+            encoding: 'utf-8',
+          })
+          .filter((item) => item.endsWith('.js'))
+        for (const file of allFilesInDotNextServerChunks) {
+          const content = await fs.readFile(
+            path.join(chunksFilesDir, file),
+            'utf8'
+          )
+          allContent += content
+        }
+
+        const pagesFilesDir = path.join(appDir, '.next', 'server', 'pages')
+        const allFilesInDotNextServerPages = await fs
+          .readdirSync(pagesFilesDir, {
+            recursive: true,
+            encoding: 'utf-8',
+          })
+          .filter((item) => item.endsWith('.js'))
+        for (const file of allFilesInDotNextServerPages) {
+          const content = await fs.readFile(
+            path.join(pagesFilesDir, file),
+            'utf8'
+          )
+          allContent += content
+        }
+
+        expect(allContent).toMatch(/Hello.*?,.*?\n?.*?("|')undefined("|')/)
+      })
+
+      it('Does not replace `typeof window` for `node_modules` code', async () => {
+        let allContent = ''
+        const files = buildManifest.pages['/'].filter((item) =>
+          item.endsWith('.js')
+        )
+        for (const file of files) {
+          const content = await fs.readFile(
+            path.join(appDir, '.next', file),
+            'utf8'
+          )
+          allContent += content
+        }
+        expect(allContent).toMatch(/MyComp:.*?,.*?typeof window/)
+      })
+    }
+  )
+})