first commit

test/integration/api-body-parser/pages/api/index.js

@@ -0,0 +1,12 @@
+export default (req, res) => {
+  if (
+    process.env.CUSTOM_SERVER &&
+    typeof req.fromCustomServer === 'undefined'
+  ) {
+    throw new Error('missing custom req field')
+  }
+
+  if (req.method === 'POST') {
+    res.status(200).json(req.body)
+  }
+}

test/integration/api-body-parser/server.js

@@ -0,0 +1,28 @@
+const next = require('next')
+const express = require('express')
+
+const dev = process.env.NODE_ENV !== 'production'
+const dir = __dirname
+const port = process.env.PORT || 3000
+
+const app = next({ dev, dir })
+const handleNextRequests = app.getRequestHandler()
+
+app.prepare().then(() => {
+  const server = express()
+
+  server.use(express.json({ limit: '5mb' }))
+
+  server.all('*', (req, res) => {
+    req.fromCustomServer = true
+    handleNextRequests(req, res)
+  })
+
+  server.listen(port, (err) => {
+    if (err) {
+      throw err
+    }
+
+    console.log(`> Ready on http://localhost:${port}`)
+  })
+})

test/integration/api-body-parser/test/index.test.ts

@@ -0,0 +1,87 @@
+/* eslint-env jest */
+
+import { join } from 'path'
+import {
+  killApp,
+  findPort,
+  launchApp,
+  fetchViaHTTP,
+  initNextServerScript,
+} from 'next-test-utils'
+import getPort from 'get-port'
+
+const appDir = join(__dirname, '../')
+let appPort: number
+
+let app
+let server
+
+const context: { appPort?: number } = {}
+
+function runTests() {
+  it('should parse JSON body', async () => {
+    appPort = await findPort()
+    app = await launchApp(appDir, appPort, {})
+    const data = await makeRequest()
+    expect(data).toEqual([{ title: 'Nextjs' }])
+    await killApp(app)
+  })
+
+  it('should not throw if request body is already parsed in custom middleware', async () => {
+    await startServer()
+    const data = await makeRequest()
+    expect(data).toEqual([{ title: 'Nextjs' }])
+    await killApp(server)
+  })
+
+  it("should not throw if request's content-type is invalid", async () => {
+    await startServer()
+    const status = await makeRequestWithInvalidContentType()
+    expect(status).toBe(200)
+    await killApp(server)
+  })
+}
+
+async function makeRequest() {
+  const data = await fetchViaHTTP(appPort, '/api', null, {
+    method: 'POST',
+    headers: {
+      'Content-Type': 'application/json; charset=utf-8',
+    },
+    body: JSON.stringify([{ title: 'Nextjs' }]),
+  }).then((res) => res.ok && res.json())
+
+  return data
+}
+
+async function makeRequestWithInvalidContentType() {
+  const status = await fetchViaHTTP(appPort, '/api', null, {
+    method: 'POST',
+    headers: {
+      'Content-Type': 'application/json;',
+    },
+    body: JSON.stringify([{ title: 'Nextjs' }]),
+  }).then((res) => res.status)
+
+  return status
+}
+
+const startServer = async (optEnv = {}, opts?: any) => {
+  const scriptPath = join(appDir, 'server.js')
+  context.appPort = appPort = await getPort()
+  const env = Object.assign(
+    { ...process.env },
+    { PORT: `${appPort}`, CUSTOM_SERVER: 'true' },
+    optEnv
+  )
+
+  server = await initNextServerScript(
+    scriptPath,
+    /ready on/i,
+    env,
+    /ReferenceError: options is not defined/,
+    opts
+  )
+}
+
+runTests()