first commit

test/e2e/app-dir/cache-components-request-apis/cache-components-request-apis.test.ts

@@ -0,0 +1,119 @@
+import { nextTestSetup } from 'e2e-utils'
+
+const stackStart = /\s+at /
+
+function createExpectError(cliOutput: string) {
+  let cliIndex = 0
+  return function expectError(
+    containing: string,
+    withStackContaining?: string
+  ) {
+    const initialCliIndex = cliIndex
+    let lines = cliOutput.slice(cliIndex).split('\n')
+
+    let i = 0
+    while (i < lines.length) {
+      let line = lines[i++] + '\n'
+      cliIndex += line.length
+      if (line.includes(containing)) {
+        if (typeof withStackContaining !== 'string') {
+          return
+        } else {
+          while (i < lines.length) {
+            let stackLine = lines[i++] + '\n'
+            if (!stackStart.test(stackLine)) {
+              expect(stackLine).toContain(withStackContaining)
+            }
+            if (stackLine.includes(withStackContaining)) {
+              return
+            }
+          }
+        }
+      }
+    }
+
+    expect(cliOutput.slice(initialCliIndex)).toContain(containing)
+  }
+}
+
+describe(`Request Promises`, () => {
+  describe('On Prerender Completion', () => {
+    const { next, isNextDev, skipped } = nextTestSetup({
+      files: __dirname + '/fixtures/reject-hanging-promises-static',
+      skipStart: true,
+    })
+
+    if (skipped) {
+      return
+    }
+
+    if (isNextDev) {
+      it('does not run in dev', () => {})
+      return
+    }
+
+    it('should reject request APIs after the prerender is complete when it finishes naturally', async () => {
+      try {
+        await next.start()
+      } catch {
+        throw new Error('expected build not to fail for fully static project')
+      }
+      const expectError = createExpectError(next.cliOutput)
+
+      expectError(
+        'Error: During prerendering, `params` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `searchParams` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `cookies()` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `headers()` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `connection()` rejects when the prerender is complete'
+      )
+    })
+  })
+  describe('On Prerender Interruption', () => {
+    const { next, isNextDev, skipped } = nextTestSetup({
+      files: __dirname + '/fixtures/reject-hanging-promises-dynamic',
+      skipStart: true,
+      skipDeployment: true,
+    })
+
+    if (skipped) {
+      return
+    }
+
+    if (isNextDev) {
+      it('does not run in dev', () => {})
+      return
+    }
+
+    it('should reject request APIs after the prerender is interrupted with synchronously dynamic APIs', async () => {
+      try {
+        await next.start()
+      } catch {}
+      const expectError = createExpectError(next.cliOutput)
+
+      expectError(
+        'Error: During prerendering, `params` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `searchParams` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `cookies()` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `headers()` rejects when the prerender is complete'
+      )
+      expectError(
+        'Error: During prerendering, `connection()` rejects when the prerender is complete'
+      )
+    })
+  })
+})

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-dynamic/app/[slug]/page.tsx

@@ -0,0 +1,37 @@
+import { cookies, headers, draftMode } from 'next/headers'
+import { connection } from 'next/server'
+
+export default async function Page(props: {
+  params: Promise<{}>
+  searchParams: Promise<{}>
+}) {
+  props.params.catch(logReason)
+  props.searchParams.catch(logReason)
+  cookies().catch(logReason)
+  headers().catch(logReason)
+  draftMode().catch(logReason)
+  connection().catch(logReason)
+  return (
+    <>
+      <p>
+        This page renders statically but it passes all of the Request Data
+        promises (cookies(), etc...) to a setTimeout scope. This test asserts
+        that these promises eventually reject even when the route is
+        synchronously dynamic (which this one is by rendering a Math.random()
+        value)
+      </p>
+      <p>
+        <TriggerSyncDynamic />
+      </p>
+    </>
+  )
+}
+
+function logReason(reason: any) {
+  console.log('Reason:', reason)
+}
+
+async function TriggerSyncDynamic() {
+  await new Promise((r) => process.nextTick(r))
+  return Math.random()
+}

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-dynamic/app/layout.tsx

@@ -0,0 +1,13 @@
+import { Suspense } from 'react'
+
+export default function Root({ children }: { children: React.ReactNode }) {
+  return (
+    <html>
+      <body>
+        <main>
+          <Suspense fallback="loading...">{children}</Suspense>
+        </main>
+      </body>
+    </html>
+  )
+}

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-dynamic/next.config.js

@@ -0,0 +1,9 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {
+  cacheComponents: true,
+  experimental: { serverMinification: true },
+}
+
+module.exports = nextConfig

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-static/app/[slug]/page.tsx

@@ -0,0 +1,28 @@
+import { cookies, headers, draftMode } from 'next/headers'
+import { connection } from 'next/server'
+
+export default async function Page(props: {
+  params: Promise<{}>
+  searchParams: Promise<{}>
+}) {
+  props.params.catch(logReason)
+  props.searchParams.catch(logReason)
+  cookies().catch(logReason)
+  headers().catch(logReason)
+  draftMode().catch(logReason)
+  connection().catch(logReason)
+  return (
+    <>
+      <p>
+        This page renders statically but it passes all of the Request Data
+        promises (cookies(), etc...) to a setTimeout scope. This test asserts
+        that these promises eventually reject even when the route is entirely
+        static (which this one is)
+      </p>
+    </>
+  )
+}
+
+function logReason(reason: any) {
+  console.log('Reason:', reason)
+}

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-static/app/layout.tsx

@@ -0,0 +1,9 @@
+export default function Root({ children }: { children: React.ReactNode }) {
+  return (
+    <html>
+      <body>
+        <main>{children}</main>
+      </body>
+    </html>
+  )
+}

test/e2e/app-dir/cache-components-request-apis/fixtures/reject-hanging-promises-static/next.config.js

@@ -0,0 +1,9 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {
+  cacheComponents: true,
+  experimental: { serverMinification: true },
+}
+
+module.exports = nextConfig