first commit

2026-03-10 19:37:31 +03:30
commit 61f56f997c
27684 changed files with 2784175 additions and 0 deletions
--- a/test/e2e/app-dir/cache-components-create-component-tree/app/favicon.ico
+++ b/test/e2e/app-dir/cache-components-create-component-tree/app/favicon.ico
--- a/test/e2e/app-dir/cache-components-create-component-tree/app/layout.tsx
+++ b/test/e2e/app-dir/cache-components-create-component-tree/app/layout.tsx
@@ -0,0 +1,38 @@
+/**
+ * This is a rather contrived test. The trick is to construct a scenario where
+ * Math.random is called during the create-component-tree phase but not during the render.
+ * To do this we patch Symbol.for. When the `react.client.reference` symbol is checked
+ * we know that this is happening in the create-component-tree function. Given the simple
+ * setup of the test page this symbol is not checked during the actual prerender itself.
+ *
+ * This test may flake in the future. It should be replaced ideally with a test that uses
+ * our OTel implementation to ensure that the built-in trace in create-component-tree does not
+ * early abort the prerender. The problem is that we are about to make these functions avoid the
+ * workUnitStore scope so it will not express the regression for other reasons.
+ */
+function patchSymbolFor() {
+  const isPatched = globalThis[Symbol.for('__SYMBOL_FOR_PATCHED__')]
+  if (!isPatched) {
+    console.log('patching')
+    globalThis[Symbol.for('__SYMBOL_FOR_PATCHED__')] = true
+
+    const originalSymbolFor = Symbol.for
+
+    Symbol.for = (...args) => {
+      if (args[0] === 'react.client.reference') {
+        Math.random()
+      }
+      return originalSymbolFor.apply(Symbol, args)
+    }
+  }
+}
+
+patchSymbolFor()
+
+export default function Root({ children }: { children: React.ReactNode }) {
+  return (
+    <html>
+      <body>{children}</body>
+    </html>
+  )
+}
--- a/test/e2e/app-dir/cache-components-create-component-tree/app/page.tsx
+++ b/test/e2e/app-dir/cache-components-create-component-tree/app/page.tsx
@@ -0,0 +1,20 @@
+export default function Page() {
+  return (
+    <>
+      <p>
+        This test does some hacky stuff to cause a `Math.random()` call to
+        happen during the component tree creation which happens before the RSC
+        render. Before the fix that this test accompanied landed this kind of
+        sync IO was reported as a problem in Dev and in runtime during start. In
+        practice this would be because of an OTEL span generation during
+        create-component-tree. With this fix in place the create-component-tree
+        function will not leak any sync IO results into the final prerender.
+      </p>
+      <p>
+        In the long run we ought to move create-component-tree into the render
+        itself and ensure the tree structure comports with CacheComponent rules.
+        This test can be deleted at that time.
+      </p>
+    </>
+  )
+}
--- a/test/e2e/app-dir/cache-components-create-component-tree/cache-components-create-component-tree.test.ts
+++ b/test/e2e/app-dir/cache-components-create-component-tree/cache-components-create-component-tree.test.ts
@@ -0,0 +1,31 @@
+import { isNextDev, nextTestSetup } from 'e2e-utils'
+import { waitForNoRedbox } from 'next-test-utils'
+
+describe('hello-world', () => {
+  const { next } = nextTestSetup({
+    files: __dirname,
+    skipStart: !isNextDev,
+    skipDeployment: true,
+  })
+
+  if (isNextDev) {
+    it('should not indicate there is an error when incidental math.random calls occur during component tree generation during dev', async () => {
+      const browser = await next.browser('/')
+      await waitForNoRedbox(browser)
+
+      // The redbox assertion is currently unreliable in this test and so this is an additional check to ensure the CLI didn't print anything with `Math.random()` in it.
+      expect(next.cliOutput).not.toContain('Math.random()')
+    })
+  } else {
+    it('should not indicate there is an error when incidental math.random calls occur during component tree generation during build', async () => {
+      try {
+        await next.build()
+      } catch (e) {
+        console.error('Expected build to Succeed, but it failed.')
+        throw e
+      }
+
+      expect(next.cliOutput).not.toContain('Math.random()')
+    })
+  }
+})
--- a/test/e2e/app-dir/cache-components-create-component-tree/next.config.js
+++ b/test/e2e/app-dir/cache-components-create-component-tree/next.config.js
@@ -0,0 +1,8 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {
+  cacheComponents: true,
+}
+
+module.exports = nextConfig