v3.1.0

Fix a bug when the checksum up-to-date resolution is used by a task with a custom label: attribute
Closes #412 Co-authored-by: Adam Wasila <adam.wasila@gmail.com>
2026-06-25 21:56:16 +00:00 · 2021-01-03 19:37:09 -03:00 · 2021-01-03 19:22:38 -03:00 · 2021-01-03 19:12:38 -03:00 · 2021-01-02 11:02:49 -03:00 · 2021-01-01 19:21:50 -03:00
21 changed files with 205 additions and 54 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -27,3 +27,4 @@ tags
 /bin
 /testdata/vars/v1
 /tmp
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -8,6 +8,10 @@ build:
  goarch:
    - 386
    - amd64
    - arm
    - arm64
  goarm:
    - 6
  ignore:
    - goos: darwin
      goarch: 386
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,7 +1,26 @@
 # Changelog
 ## v3.1.0
 - Fix a bug when the checksum up-to-date resolution is used by a task
  with a custom `label:` attribute
  ([#412](https://github.com/go-task/task/issues/412)).
 - Starting from this release, we're releasing official ARMv6 and ARM64 binaries
  for Linux
  ([#375](https://github.com/go-task/task/issues/375), [#418](https://github.com/go-task/task/issues/418)).
 - Task now respects the order of declaration of included Taskfiles when
  evaluating variables declaring by them
  ([#393](https://github.com/go-task/task/issues/393)).
 - `set -e` is now automatically set on every command. This was done to fix an
  issue where multiline string commands wouldn't really fail unless the
  sentence was in the last line
  ([#403](https://github.com/go-task/task/issues/403)).
 ## v3.0.1
 - Allow use as a library by moving the required packages out of the `internal`
  directory
  ([#358](https://github.com/go-task/task/pull/358)).
 - Do not error if a specified dotenv file does not exist
  ([#378](https://github.com/go-task/task/issues/378), [#385](https://github.com/go-task/task/pull/385)).
 - Fix panic when you have empty tasks in your Taskfile
--- a/README.md
+++ b/README.md
@@ -1,10 +1,15 @@
-![Test](https://github.com/go-task/task/workflows/Test/badge.svg)
+<div align="center">
-![GoReleaser](https://github.com/go-task/task/workflows/goreleaser/badge.svg)
+  <a href="https://taskfile.dev">
-![GitHub All Releases](https://img.shields.io/github/downloads/go-task/task/total)
+    <img src="docs/Logo.png" width="200px" height="200px" />
  </a>
-# Task
+  <h1>Task</h1>
-Task is a task runner / build tool that aims to be simpler and easier to use
+  <p>
-than, for example, [GNU Make](https://www.gnu.org/software/make/).
+    Task is a task runner / build tool that aims to be simpler and easier to use than, for example, <a href="https://www.gnu.org/software/make/">GNU Make<a>.
  </p>
-See [taskfile.dev](https://taskfile.dev) for the documentation.
+  <p>
    See <a href="https://taskfile.dev">taskfile.dev</a> for the documentation.
  </p>
 </div>
--- a/docs/Logo.png
+++ b/docs/Logo.png
--- a/docs/README.md
+++ b/docs/README.md
@@ -1,5 +1,9 @@
 # Task
 <div align="center">
  <img id="logo" src="/Logo.png" height="250px" width="250px" />
 </div>
 Task is a task runner / build tool that aims to be simpler and easier to use
 than, for example, [GNU Make][make].
--- a/docs/Taskfile.yml
+++ b/docs/Taskfile.yml
@@ -10,3 +10,8 @@ tasks:
    desc: Serves the documentation site locally
    cmds:
      - docsify serve .
  ico:
    desc: Generate favicon.ico from Logo.png
    cmds:
      - convert -background transparent "Logo.png" -define icon:auto-resize=16,24,32,48,64,72,96,128,256 "favicon.ico"
--- a/docs/favicon.ico
+++ b/docs/favicon.ico
--- a/docs/index.html
+++ b/docs/index.html
@@ -8,6 +8,19 @@
    <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
    <link rel="stylesheet" href="//cdn.jsdelivr.net/npm/docsify-themeable/dist/css/theme-simple.css">
    <meta name="google-site-verification" content="VGAYkbdmuaciIDGkBe-eAg9yfZg0C6ostgonbGxxOa0" />
    <style>
      #logo {
        transition: all 0.7s ease;
      }
      #logo:hover {
        -webkit-transform: rotateZ(360deg);
        -ms-transform: rotateZ(360deg);
        transform: rotateZ(360deg);
      }
      .app-name-link img {
        width: 125px;
      }
    </style>
  </head>
  <body>
    <div id="app"></div>
@@ -15,7 +28,8 @@
      window.$docsify = {
        name: 'Task',
        repo: 'go-task/task',
-        themeColor: '#00add8',
+        logo: 'Logo.png',
        themeColor: '#29beb0',
        loadSidebar: true,
        auto2top: true,
        maxLevel: 3,
--- a/docs/usage.md
+++ b/docs/usage.md
@@ -269,16 +269,16 @@ attribute:
 version: '3'
 tasks:
-  main-task:
+  greet:
    vars:
      RECIPIENT: '{{default "World" .RECIPIENT}}'
    cmds:
-      - task: write-file
+      - echo "Hello, {{.RECIPIENT}}!"
        vars: {FILE: "hello.txt", CONTENT: "Hello!"}
      - task: write-file
        vars: {FILE: "world.txt", CONTENT: "World!"}
-  write-file:
+  greet-pessimistically:
    cmds:
-      - echo "{{.CONTENT}}" > {{.FILE}}
+      - task: greet
        vars: {RECIPIENT: "Cruel World"}
 ```
 The above syntax is also supported in `deps`.
@@ -865,7 +865,7 @@ $ task default
 ## Short task syntax
 Starting on Task v3, you can now write tasks with a shorter syntax if they
-have the default settings (e.g. no custom `env:`, `vars:`, `silent:` , etc):
+have the default settings (e.g. no custom `env:`, `vars:`, `desc:`, `silent:` , etc):
 ```yaml
 version: '3'
@@ -873,7 +873,7 @@ version: '3'
 tasks:
  build: go build -v -o ./app{{exeExt}} .
-  build:
+  run:
    - task: build
    - ./app{{exeExt}} -h localhost -p 8080
 ```
--- a/internal/execext/exec.go
+++ b/internal/execext/exec.go
@@ -46,16 +46,10 @@ func RunCommand(ctx context.Context, opts *RunCommandOptions) error {
 	}
 	r, err := interp.New(
 		interp.Params("-e"),
 		interp.Dir(opts.Dir),
 		interp.Env(expand.ListEnviron(environ...)),
-
+		interp.OpenHandler(openHandler),
 		interp.OpenHandler(func(ctx context.Context, path string, flag int, perm os.FileMode) (io.ReadWriteCloser, error) {
 			if path == "/dev/null" {
 				return devNull{}, nil
 			}
 			return interp.DefaultOpenHandler()(ctx, path, flag, perm)
 		}),
 		interp.StdIO(opts.Stdin, opts.Stdout, opts.Stderr),
 	)
 	if err != nil {
@@ -86,3 +80,10 @@ func Expand(s string) (string, error) {
 	}
 	return "", nil
 }
 func openHandler(ctx context.Context, path string, flag int, perm os.FileMode) (io.ReadWriteCloser, error) {
 	if path == "/dev/null" {
 		return devNull{}, nil
 	}
 	return interp.DefaultOpenHandler()(ctx, path, flag, perm)
 }
--- a/status.go
+++ b/status.go
@@ -77,7 +77,7 @@ func (e *Executor) timestampChecker(t *taskfile.Task) status.Checker {
 func (e *Executor) checksumChecker(t *taskfile.Task) status.Checker {
 	return &status.Checksum{
 		Dir:       t.Dir,
-		Task:      t.Task,
+		Task:      t.Name(),
 		Sources:   t.Sources,
 		Generates: t.Generates,
 		Dry:       e.Dry,
--- a/task.go
+++ b/task.go
@@ -176,7 +176,7 @@ func (e *Executor) Setup() error {
 	if v < 2.1 && e.Taskfile.Output != "" {
 		return fmt.Errorf(`task: Taskfile option "output" is only available starting on Taskfile version v2.1`)
 	}
-	if v < 2.2 && len(e.Taskfile.Includes) > 0 {
+	if v < 2.2 && e.Taskfile.Includes.Len() > 0 {
 		return fmt.Errorf(`task: Including Taskfiles is only available starting on Taskfile version v2.2`)
 	}
 	if v >= 3.0 && e.Taskfile.Expansions > 2 {
@@ -229,10 +229,14 @@ func (e *Executor) Setup() error {
 	}
 	if v < 3 {
-		for _, taskfile := range e.Taskfile.Includes {
+		err := e.Taskfile.Includes.Range(func(_ string, taskfile taskfile.IncludedTaskfile) error {
 			if taskfile.AdvancedImport {
 				return errors.New(`task: Import with additional parameters is only available starting on Taskfile version v3`)
 			}
 			return nil
 		})
 		if err != nil {
 			return err
 		}
 	}
--- a/task_test.go
+++ b/task_test.go
@@ -868,3 +868,19 @@ func TestDotenvShouldAllowMissingEnv(t *testing.T) {
 	}
 	tt.Run(t)
 }
 func TestExitImmediately(t *testing.T) {
 	const dir = "testdata/exit_immediately"
 	var buff bytes.Buffer
 	e := task.Executor{
 		Dir:    dir,
 		Stdout: &buff,
 		Stderr: &buff,
 		Silent: true,
 	}
 	assert.NoError(t, e.Setup())
 	assert.Error(t, e.Run(context.Background(), taskfile.Call{Task: "default"}))
 	assert.Contains(t, buff.String(), `"this_should_fail": executable file not found in $PATH`)
 }
--- a/taskfile/included_taskfile.go
+++ b/taskfile/included_taskfile.go
@@ -1,6 +1,10 @@
 package taskfile
-import "errors"
+import (
 	"errors"
 	"gopkg.in/yaml.v3"
 )
 var (
 	// ErrCantUnmarshalIncludedTaskfile is returned for invalid var YAML.
@@ -15,7 +19,72 @@ type IncludedTaskfile struct {
 }
 // IncludedTaskfiles represents information about included tasksfiles
-type IncludedTaskfiles = map[string]IncludedTaskfile
+type IncludedTaskfiles struct {
 	Keys    []string
 	Mapping map[string]IncludedTaskfile
 }
 // UnmarshalYAML implements the yaml.Unmarshaler interface.
 func (tfs *IncludedTaskfiles) UnmarshalYAML(node *yaml.Node) error {
 	if node.Kind != yaml.MappingNode {
 		return errors.New("task: includes is not a map")
 	}
 	// NOTE(@andreynering): on this style of custom unmarsheling,
 	// even number contains the keys, while odd numbers contains
 	// the values.
 	for i := 0; i < len(node.Content); i += 2 {
 		keyNode := node.Content[i]
 		valueNode := node.Content[i+1]
 		var v IncludedTaskfile
 		if err := valueNode.Decode(&v); err != nil {
 			return err
 		}
 		tfs.Set(keyNode.Value, v)
 	}
 	return nil
 }
 // Len returns the length of the map
 func (tfs *IncludedTaskfiles) Len() int {
 	if tfs == nil {
 		return 0
 	}
 	return len(tfs.Keys)
 }
 // Merge merges the given IncludedTaskfiles into the caller one
 func (tfs *IncludedTaskfiles) Merge(other *IncludedTaskfiles) {
 	other.Range(func(key string, value IncludedTaskfile) error {
 		tfs.Set(key, value)
 		return nil
 	})
 }
 // Set sets a value to a given key
 func (tfs *IncludedTaskfiles) Set(key string, includedTaskfile IncludedTaskfile) {
 	if tfs.Mapping == nil {
 		tfs.Mapping = make(map[string]IncludedTaskfile, 1)
 	}
 	if !stringSliceContains(tfs.Keys, key) {
 		tfs.Keys = append(tfs.Keys, key)
 	}
 	tfs.Mapping[key] = includedTaskfile
 }
 // Range allows you to loop into the included taskfiles in its right order
 func (tfs *IncludedTaskfiles) Range(yield func(key string, includedTaskfile IncludedTaskfile) error) error {
 	if tfs == nil {
 		return nil
 	}
 	for _, k := range tfs.Keys {
 		if err := yield(k, tfs.Mapping[k]); err != nil {
 			return err
 		}
 	}
 	return nil
 }
 // UnmarshalYAML implements yaml.Unmarshaler interface
 func (it *IncludedTaskfile) UnmarshalYAML(unmarshal func(interface{}) error) error {
--- a/taskfile/merge.go
+++ b/taskfile/merge.go
@@ -22,11 +22,9 @@ func Merge(t1, t2 *Taskfile, namespaces ...string) error {
 	}
 	if t1.Includes == nil {
-		t1.Includes = make(IncludedTaskfiles)
+		t1.Includes = &IncludedTaskfiles{}
 	}
 	for k, v := range t2.Includes {
 		t1.Includes[k] = v
 	}
 	t1.Includes.Merge(t2.Includes)
 	if t1.Vars == nil {
 		t1.Vars = &Vars{}
--- a/taskfile/read/taskfile.go
+++ b/taskfile/read/taskfile.go
@@ -58,7 +58,7 @@ func Taskfile(dir string, entrypoint string) (*taskfile.Taskfile, error) {
 		}
 	}
-	for namespace, includedTask := range t.Includes {
+	err = t.Includes.Range(func(namespace string, includedTask taskfile.IncludedTaskfile) error {
 		if v >= 3.0 {
 			tr := templater.Templater{Vars: &taskfile.Vars{}, RemoveNoValue: true}
 			includedTask = taskfile.IncludedTaskfile{
@@ -67,7 +67,7 @@ func Taskfile(dir string, entrypoint string) (*taskfile.Taskfile, error) {
 				AdvancedImport: includedTask.AdvancedImport,
 			}
 			if err := tr.Err(); err != nil {
-				return nil, err
+				return err
 			}
 		}
@@ -79,21 +79,21 @@ func Taskfile(dir string, entrypoint string) (*taskfile.Taskfile, error) {
 		info, err := os.Stat(path)
 		if err != nil {
-			return nil, err
+			return err
 		}
 		if info.IsDir() {
 			path = filepath.Join(path, "Taskfile.yml")
 		}
 		includedTaskfile, err := readTaskfile(path)
 		if err != nil {
-			return nil, err
+			return err
 		}
-		if len(includedTaskfile.Includes) > 0 {
+		if includedTaskfile.Includes.Len() > 0 {
-			return nil, ErrIncludedTaskfilesCantHaveIncludes
+			return ErrIncludedTaskfilesCantHaveIncludes
 		}
 		if v >= 3.0 && len(includedTaskfile.Dotenv) > 0 {
-			return nil, ErrIncludedTaskfilesCantHaveDotenvs
+			return ErrIncludedTaskfilesCantHaveDotenvs
 		}
 		if includedTask.AdvancedImport {
@@ -105,8 +105,12 @@ func Taskfile(dir string, entrypoint string) (*taskfile.Taskfile, error) {
 		}
 		if err = taskfile.Merge(t, includedTaskfile, namespace); err != nil {
-			return nil, err
+			return err
 		}
 		return nil
 	})
 	if err != nil {
 		return nil, err
 	}
 	if v < 3.0 {
--- a/taskfile/slice.go
+++ b/taskfile/slice.go
@@ -0,0 +1,10 @@
 package taskfile
 func stringSliceContains(s []string, str string) bool {
 	for _, v := range s {
 		if v == str {
 			return true
 		}
 	}
 	return false
 }
--- a/taskfile/taskfile.go
+++ b/taskfile/taskfile.go
@@ -11,7 +11,7 @@ type Taskfile struct {
 	Expansions int
 	Output     string
 	Method     string
-	Includes   IncludedTaskfiles
+	Includes   *IncludedTaskfiles
 	Vars       *Vars
 	Env        *Vars
 	Tasks      Tasks
@@ -26,7 +26,7 @@ func (tf *Taskfile) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		Expansions int
 		Output     string
 		Method     string
-		Includes   IncludedTaskfiles
+		Includes   *IncludedTaskfiles
 		Vars       *Vars
 		Env        *Vars
 		Tasks      Tasks
--- a/taskfile/var.go
+++ b/taskfile/var.go
@@ -53,21 +53,12 @@ func (vs *Vars) Set(key string, value Var) {
 	if vs.Mapping == nil {
 		vs.Mapping = make(map[string]Var, 1)
 	}
-	if !strSliceContains(vs.Keys, key) {
+	if !stringSliceContains(vs.Keys, key) {
 		vs.Keys = append(vs.Keys, key)
 	}
 	vs.Mapping[key] = value
 }
 func strSliceContains(s []string, str string) bool {
 	for _, v := range s {
 		if v == str {
 			return true
 		}
 	}
 	return false
 }
 // Range allows you to loop into the vars in its right order
 func (vs *Vars) Range(yield func(key string, value Var) error) error {
 	if vs == nil {
--- a/testdata/exit_immediately/Taskfile.yml
+++ b/testdata/exit_immediately/Taskfile.yml
@@ -0,0 +1,6 @@
 version: '3'
 tasks:
  default: |
    this_should_fail
    echo "This shoudn't be print"
Author	SHA1	Message	Date
Andrey Nering	9b2e25735b	v3.1.0	2021-01-03 19:37:09 -03:00
Andrey Nering	e09e75b0ba	Fix a bug when the checksum up-to-date resolution is used by a task with a custom `label:` attribute Closes #412 Co-authored-by: Adam Wasila <adam.wasila@gmail.com>	2021-01-03 19:22:38 -03:00
Andrey Nering	6630113fef	Release ARMv6 and ARM64 binaries on Linux Closes #375 Closes #418	2021-01-03 19:12:38 -03:00
Andrey Nering	b2f08c9c20	Merge pull request #415 from felladrin/patch-1 Fix duplicate task name on "Short task syntax" example	2021-01-02 11:02:49 -03:00
Andrey Nering	6a4315b7e7	Merge pull request #407 from bryceschober/patch-1 Use {{default}} for an overriding usage	2021-01-01 19:21:50 -03:00
Andrey Nering	8b3e62ff6d	Add forgotten CHANGELOG entry for #358 Ref #121	2021-01-01 19:06:00 -03:00
Andrey Nering	f1d3f6740d	Update CHANGELOG.md	2021-01-01 18:57:28 -03:00
Andrey Nering	9ccd1d920c	.gitignore: Add /tmp	2021-01-01 18:30:14 -03:00
Andrey Nering	9674d75ff6	Evaluate included taskfiles in order of declaration Closes #393	2021-01-01 18:27:50 -03:00
Andrey Nering	22fd74846d	Use `interp.Params("-e")` intead of running "set -e" manually This is an improvement for `ac8e344173`	2021-01-01 17:32:42 -03:00
Andrey Nering	777645888a	New logo and color	2020-12-27 19:07:38 -03:00
Andrey Nering	ac8e344173	Run "set -e" automatically for every command Without this, multiline command strings won't always exit when they fail. Closes #403	2020-12-27 17:15:12 -03:00
Andrey Nering	16fad60833	execext: Small refactor	2020-12-27 16:51:00 -03:00
Victor Nogueira	f5eb80759b	Fix duplicate task name on "Short task syntax" example To make it a valid YAML file and avoid the error: ``` yaml: unmarshal errors: line 6: mapping key "build" already defined at line 4 ```	2020-12-07 13:00:25 +02:00
Bryce Schober	bf88bd5da5	Use {{default}} for an overriding usage Fixes documentation confusion raised in #376.	2020-11-18 17:09:44 -08:00