Refactor: Add SmartJoin to handle IsAbs automatically

internal/compiler/v3/compiler_v3.go

@@ -4,12 +4,12 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"path/filepath"
 	"strings"
 	"sync"
 
 	"github.com/go-task/task/v3/internal/compiler"
 	"github.com/go-task/task/v3/internal/execext"
+	"github.com/go-task/task/v3/internal/filepathext"
 	"github.com/go-task/task/v3/internal/logger"
 	"github.com/go-task/task/v3/internal/templater"
 	"github.com/go-task/task/v3/taskfile"
@@ -83,9 +83,7 @@ func (c *CompilerV3) getVariables(t *taskfile.Task, call *taskfile.Call, evaluat
 		if err := tr.Err(); err != nil {
 			return nil, err
 		}
-		if !filepath.IsAbs(dir) {
-			dir = filepath.Join(c.Dir, dir)
-		}
+		dir = filepathext.SmartJoin(c.Dir, dir)
 		taskRangeFunc = getRangeFunc(dir)
 	}
 

internal/filepathext/filepathext.go

@@ -0,0 +1,14 @@
+package filepathext
+
+import (
+	"path/filepath"
+)
+
+// SmartJoin joins two paths, but only if the second is not already an
+// absolute path.
+func SmartJoin(a, b string) string {
+	if filepath.IsAbs(b) {
+		return b
+	}
+	return filepath.Join(a, b)
+}

internal/status/checksum.go

@@ -8,6 +8,8 @@ import (
 	"path/filepath"
 	"regexp"
 	"strings"
+
+	"github.com/go-task/task/v3/internal/filepathext"
 )
 
 // Checksum validades if a task is up to date by calculating its source
@@ -43,7 +45,7 @@ func (c *Checksum) IsUpToDate() (bool, error) {
 	}
 
 	if !c.Dry {
-		_ = os.MkdirAll(filepath.Join(c.TempDir, "checksum"), 0755)
+		_ = os.MkdirAll(filepathext.SmartJoin(c.TempDir, "checksum"), 0755)
 		if err = os.WriteFile(checksumFile, []byte(newMd5+"\n"), 0644); err != nil {
 			return false, err
 		}

internal/status/glob.go

@@ -2,12 +2,12 @@ package status
 
 import (
 	"os"
-	"path/filepath"
 	"sort"
 
 	"github.com/mattn/go-zglob"
 
 	"github.com/go-task/task/v3/internal/execext"
+	"github.com/go-task/task/v3/internal/filepathext"
 )
 
 func globs(dir string, globs []string) ([]string, error) {
@@ -25,17 +25,18 @@ func globs(dir string, globs []string) ([]string, error) {
 
 func Glob(dir string, g string) ([]string, error) {
 	files := make([]string, 0)
-	if !filepath.IsAbs(g) {
-		g = filepath.Join(dir, g)
-	}
+	g = filepathext.SmartJoin(dir, g)
+
 	g, err := execext.Expand(g)
 	if err != nil {
 		return nil, err
 	}
+
 	fs, err := zglob.Glob(g)
 	if err != nil {
 		return nil, err
 	}
+
 	for _, f := range fs {
 		info, err := os.Stat(f)
 		if err != nil {