From 659cae6a4c93eb25e2b356801d09cd2feb4c82d7 Mon Sep 17 00:00:00 2001 From: Stephen Prater Date: Tue, 28 May 2019 12:28:29 -0700 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: Andrey Nering --- docs/taskfile_versions.md | 4 ++-- internal/taskfile/task.go | 2 +- variables.go | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/taskfile_versions.md b/docs/taskfile_versions.md index b56bd1ce..a318f12a 100644 --- a/docs/taskfile_versions.md +++ b/docs/taskfile_versions.md @@ -141,9 +141,9 @@ includes: docker: ./DockerTasks.yml ``` -## Version 2.3 +## Version 2.6 -Version 2.3 comes with `preconditions` stanza in tasks. +Version 2.6 comes with `preconditions` stanza in tasks. ```yaml version: '2' diff --git a/internal/taskfile/task.go b/internal/taskfile/task.go index 9c1cf3b3..bc4bf981 100644 --- a/internal/taskfile/task.go +++ b/internal/taskfile/task.go @@ -13,7 +13,7 @@ type Task struct { Sources []string Generates []string Status []string - Precondition []*Precondition + Preconditions []*Precondition Dir string Vars Vars Env Vars diff --git a/variables.go b/variables.go index 0f3c7f96..5af5f873 100644 --- a/variables.go +++ b/variables.go @@ -73,7 +73,6 @@ func (e *Executor) CompiledTask(call taskfile.Call) (*taskfile.Task, error) { IgnoreError: cmd.IgnoreError, } } - } if len(origTask.Deps) > 0 { new.Deps = make([]*taskfile.Dep, len(origTask.Deps))