execext: use sync.Pool to instantiate parser and runner

A benchmark was added. The performance improvement is considerable:

BenchmarkNoPool-4   	   30000	     43405 ns/op
BenchmarkPool-4     	   20000	     71219 ns/op
This commit is contained in:
Andrey Nering
2017-09-02 11:32:24 -03:00
parent 2b2852aad7
commit 451b965fb0
2 changed files with 98 additions and 9 deletions

View File

@@ -5,11 +5,26 @@ import (
"errors"
"io"
"strings"
"sync"
"mvdan.cc/sh/interp"
"mvdan.cc/sh/syntax"
)
var (
parserPool = sync.Pool{
New: func() interface{} {
return syntax.NewParser()
},
}
runnerPool = sync.Pool{
New: func() interface{} {
return &interp.Runner{}
},
}
)
// RunCommandOptions is the options for the RunCommand func
type RunCommandOptions struct {
Context context.Context
@@ -32,19 +47,24 @@ func RunCommand(opts *RunCommandOptions) error {
return ErrNilOptions
}
p, err := syntax.NewParser().Parse(strings.NewReader(opts.Command), "")
parser := parserPool.Get().(*syntax.Parser)
defer parserPool.Put(parser)
p, err := parser.Parse(strings.NewReader(opts.Command), "")
if err != nil {
return err
}
r := interp.Runner{
Context: opts.Context,
Dir: opts.Dir,
Env: opts.Env,
Stdin: opts.Stdin,
Stdout: opts.Stdout,
Stderr: opts.Stderr,
}
r := runnerPool.Get().(*interp.Runner)
defer runnerPool.Put(r)
r.Context = opts.Context
r.Dir = opts.Dir
r.Env = opts.Env
r.Stdin = opts.Stdin
r.Stdout = opts.Stdout
r.Stderr = opts.Stderr
if err = r.Reset(); err != nil {
return err
}