rayan/go-task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2026-06-30 16:14:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: optimize task filtering (#982)

Browse Source
This commit is contained in:
Pete Davison
2023-01-14 13:45:52 -06:00
committed by GitHub
parent 1c1be683ab
commit 2da7ddc399
2 changed files with 38 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
help.go
View File

@@ -51,10 +51,10 @@ func (o ListOptions) Validate() error {
// Filters returns the slice of FilterFunc which filters a list
// of taskfile.Task according to the given ListOptions
func (o ListOptions) Filters() []FilterFunc {
filters := []FilterFunc{FilterOutInternal()}
filters := []FilterFunc{FilterOutInternal}
if o.ListOnlyTasksWithDescriptions {
filters = append(filters, FilterOutNoDesc())
filters = append(filters, FilterOutNoDesc)
}
return filters
@@ -65,7 +65,10 @@ func (o ListOptions) Filters() []FilterFunc {
// The function returns a boolean indicating whether tasks were found
// and an error if one was encountered while preparing the output.
func (e *Executor) ListTasks(o ListOptions) (bool, error) {
tasks := e.GetTaskList(o.Filters()...)
tasks, err := e.GetTaskList(o.Filters()...)
if err != nil {
return false, err
}
if o.FormatTaskListAsJSON {
output, err := e.ToEditorOutput(tasks)
if err != nil {