mirror of
https://github.com/usebruno/bruno.git
synced 2026-06-15 11:51:30 +00:00
fa1498e2a8
* Fix the space encoding issue * fix: incorrect space encoding Fixed an issue in Code Generation for requests. The original fix was raised in [PR](https://github.com/usebruno/bruno/pull/4478). The current PR fixes some merge conflicts and resolves some unimported dependencies error. * test: add URL encoding tests for code generation feature Add Playwright tests to verify proper URL encoding behavior in Bruno's code generation dialog for both encoded and unencoded query parameters. * moved the test script inside request * updated the snippet generation code to reuse code and reduce redundancy * removed redundant code and reverted autoformat * reverted some auto formatted changes * reverting format during commit hook * chore: reset formatting * chore: reformat --------- Co-authored-by: Vipin Sundar <86339268+vipin-sundar@users.noreply.github.com> Co-authored-by: Chirag Chandrashekhar <chiragchan@Chirags-MacBook-Air.local> Co-authored-by: Sid <siddharth@usebruno.com> chore: reformat
101 lines
4.6 KiB
TypeScript
101 lines
4.6 KiB
TypeScript
import { test, expect } from '../../../playwright';
|
|
import { closeAllCollections } from '../../utils/page';
|
|
|
|
test.describe('Code Generation URL Encoding', () => {
|
|
test.afterEach(async ({ pageWithUserData: page }) => {
|
|
try {
|
|
const modalCloseButton = page.locator('[data-test-id="modal-close-button"]');
|
|
if (await modalCloseButton.isVisible()) {
|
|
await modalCloseButton.click();
|
|
await modalCloseButton.waitFor({ state: 'hidden' });
|
|
}
|
|
} catch (e) {}
|
|
|
|
await closeAllCollections(page);
|
|
});
|
|
|
|
test('Should generate code with proper URL encoding for unencoded input', async ({
|
|
pageWithUserData: page,
|
|
createTmpDir
|
|
}) => {
|
|
await page.locator('.dropdown-icon').click();
|
|
await page.locator('.dropdown-item').filter({ hasText: 'Create Collection' }).click();
|
|
await page.getByLabel('Name').fill('unencoded-test-collection');
|
|
await page.getByLabel('Location').fill(await createTmpDir('unencoded-test-collection'));
|
|
await page.getByRole('button', { name: 'Create', exact: true }).click();
|
|
|
|
await expect(page.locator('#sidebar-collection-name').filter({ hasText: 'unencoded-test-collection' })).toBeVisible();
|
|
await page.locator('#sidebar-collection-name').filter({ hasText: 'unencoded-test-collection' }).click();
|
|
await page.getByLabel('Safe Mode').check();
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
|
|
await page.locator('#create-new-tab').getByRole('img').click();
|
|
await page.getByPlaceholder('Request Name').fill('unencoded-request');
|
|
await page.locator('#new-request-url .CodeMirror').click();
|
|
await page.locator('textarea').fill('http://base.source?name=John Doe');
|
|
await page.getByRole('button', { name: 'Create' }).click();
|
|
|
|
await expect(page.locator('.collection-item-name').filter({ hasText: 'unencoded-request' })).toBeVisible();
|
|
|
|
await page.locator('.collection-item-name').filter({ hasText: 'unencoded-request' }).click();
|
|
|
|
await page.locator('#send-request .infotip').first().click();
|
|
|
|
await expect(page.getByRole('dialog')).toBeVisible();
|
|
await expect(page.getByRole('dialog').locator('.bruno-modal-header-title')).toContainText('Generate Code');
|
|
|
|
const codeEditor = page.locator('.editor-content .CodeMirror').first();
|
|
await expect(codeEditor).toBeVisible();
|
|
|
|
const generatedCode = await codeEditor.textContent();
|
|
|
|
expect(generatedCode).toContain('http://base.source/?name=John%20Doe');
|
|
|
|
await page.locator('[data-test-id="modal-close-button"]').click();
|
|
|
|
await page.locator('[data-test-id="modal-close-button"]').waitFor({ state: 'hidden' });
|
|
});
|
|
|
|
test('Should generate code with proper URL encoding for encoded input', async ({
|
|
pageWithUserData: page,
|
|
createTmpDir
|
|
}) => {
|
|
await page.locator('.dropdown-icon').click();
|
|
await page.locator('.dropdown-item').filter({ hasText: 'Create Collection' }).click();
|
|
await page.getByLabel('Name').fill('encoded-test-collection');
|
|
await page.getByLabel('Location').fill(await createTmpDir('encoded-test-collection'));
|
|
await page.getByRole('button', { name: 'Create', exact: true }).click();
|
|
|
|
await expect(page.locator('#sidebar-collection-name').filter({ hasText: 'encoded-test-collection' })).toBeVisible();
|
|
await page.locator('#sidebar-collection-name').filter({ hasText: 'encoded-test-collection' }).click();
|
|
await page.getByLabel('Safe Mode').check();
|
|
await page.getByRole('button', { name: 'Save' }).click();
|
|
|
|
await page.locator('#create-new-tab').getByRole('img').click();
|
|
await page.getByPlaceholder('Request Name').fill('encoded-request');
|
|
await page.locator('#new-request-url .CodeMirror').click();
|
|
await page.locator('textarea').fill('http://base.source?name=John%20Doe');
|
|
await page.getByRole('button', { name: 'Create' }).click();
|
|
|
|
await expect(page.locator('.collection-item-name').filter({ hasText: 'encoded-request' })).toBeVisible();
|
|
|
|
await page.locator('.collection-item-name').filter({ hasText: 'encoded-request' }).click();
|
|
|
|
await page.locator('#send-request .infotip').first().click();
|
|
|
|
await expect(page.getByRole('dialog')).toBeVisible();
|
|
await expect(page.getByRole('dialog').locator('.bruno-modal-header-title')).toContainText('Generate Code');
|
|
|
|
const codeEditor = page.locator('.editor-content .CodeMirror').first();
|
|
await expect(codeEditor).toBeVisible();
|
|
|
|
const generatedCode = await codeEditor.textContent();
|
|
|
|
expect(generatedCode).toContain('http://base.source/?name=John%20Doe');
|
|
|
|
await page.locator('[data-test-id="modal-close-button"]').click();
|
|
|
|
await page.locator('[data-test-id="modal-close-button"]').waitFor({ state: 'hidden' });
|
|
});
|
|
});
|