mirror of
https://github.com/usebruno/bruno.git
synced 2026-06-24 21:25:45 +00:00
21efded2bf
The 'websocket requests are visible' test calls expect(page.locator(...)).toBeVisible() without awaiting it. A Playwright web-first matcher returns a Promise that polls and retries until the element matches or the timeout elapses. When the expect is not awaited the Promise is created and immediately discarded, so the assertion never runs and the test passes whether or not the request is visible in the sidebar. This is the sole assertion in that test, so the test gave no real coverage. The six other expect calls in the same file are already awaited, so this brings the line in line with the file's own idiom. Signed-off-by: YONGJAE LEE <dev.yongjaelee@gmail.com>
54 lines
2.3 KiB
TypeScript
54 lines
2.3 KiB
TypeScript
import { expect, test } from '../../playwright';
|
|
import { buildWebsocketCommonLocators } from '../utils/page/locators';
|
|
|
|
const MAX_CONNECTION_TIME = 3000;
|
|
const BRU_REQ_NAME = /^ws-test-request$/;
|
|
|
|
test.describe.serial('websockets', () => {
|
|
test('websocket requests are visible', async ({ pageWithUserData: page, restartApp }) => {
|
|
await page.locator('#sidebar-collection-name').click();
|
|
|
|
await expect(page.locator('span.item-name').filter({ hasText: BRU_REQ_NAME })).toBeVisible();
|
|
});
|
|
|
|
test('websocket connects', async ({ pageWithUserData: page, restartApp }) => {
|
|
const locators = buildWebsocketCommonLocators(page);
|
|
|
|
// Attempt a connection for the specified request
|
|
await page.getByTitle(BRU_REQ_NAME).click();
|
|
await locators.connectionControls.connect().click();
|
|
|
|
// See if the socket connected by monitoring the opposite state
|
|
await expect(locators.connectionControls.disconnect()).toBeAttached({
|
|
timeout: MAX_CONNECTION_TIME
|
|
});
|
|
});
|
|
|
|
test('websocket closes', async ({ pageWithUserData: page, restartApp }) => {
|
|
const locators = buildWebsocketCommonLocators(page);
|
|
await locators.connectionControls.disconnect().click();
|
|
|
|
// See if the socket disconnected by monitoring the opposite state
|
|
await expect(locators.connectionControls.connect()).toBeVisible();
|
|
});
|
|
|
|
test('websocket messages were recorded', async ({ pageWithUserData: page, restartApp }) => {
|
|
const locators = buildWebsocketCommonLocators(page);
|
|
|
|
// Hard validate the recieved messages to confirm the connection state
|
|
await expect(locators.messages().first().getByText('Connected to ws://')).toBeAttached();
|
|
await expect(locators.messages().nth(1).getByText('Closed')).toBeAttached();
|
|
});
|
|
|
|
test('websocket request can send messages', async ({ pageWithUserData: page, restartApp }) => {
|
|
const locators = buildWebsocketCommonLocators(page);
|
|
|
|
await locators.toolbar.clearResponse().click();
|
|
await locators.runner().click();
|
|
|
|
// Check if the messages from the request are actually displayed on the messages container
|
|
await expect(locators.messages().nth(1).locator('.text-ellipsis')).toHaveText('{ "foo": "bar" }');
|
|
await expect(locators.messages().nth(2).locator('.text-ellipsis')).toHaveText('{ "data": { "foo": "bar" } }');
|
|
});
|
|
});
|