Files
bruno/tests/preferences/default-collection-location/default-collection-location.spec.js
gopu-bruno 707fd405ff Fix: resolve default location missing path (#7391)
* fix: refocus collection name input on error and resolve missing default location folder

* revert: remove focus refocus logic from InlineCollectionCreator

Reverts the setTimeout focus change that was causing test failures.
Keeps the preferences.js fix for default location validation.

Made-with: Cursor

* fix: update default-collection-location test to use project path

Use {{projectRoot}} template variable for defaultLocation so the path
exists when the app validates it with fs.existsSync.

Made-with: Cursor

* fix: improve save test to use alternate path and verify persistence

Made-with: Cursor

---------

Co-authored-by: naman-bruno <naman@usebruno.com>
2026-03-07 00:23:01 +05:30

131 lines
5.4 KiB
JavaScript

import { test, expect } from '../../../playwright';
const EXPECTED_PATH_SUFFIX = 'tests/preferences/default-collection-location';
test.describe('Default Location Feature', () => {
test('Should hydrate the default location from preferences', async ({ pageWithUserData: page }) => {
// open preferences tab
await page.locator('.preferences-button').click();
// wait for preferences tab to be visible
await page.waitForTimeout(500);
// navigate to General tab
await page.getByRole('tab', { name: 'General' }).click();
// verify the default location is pre-filled with the expected path suffix
const defaultLocationInput = page.locator('.default-location-input');
const value = await defaultLocationInput.inputValue();
expect(value.endsWith(EXPECTED_PATH_SUFFIX)).toBe(true);
});
test('Should save a valid default location', async ({ pageWithUserData: page }) => {
// open preferences tab
await page.locator('.preferences-button').click();
// wait for preferences tab to be visible
await page.waitForTimeout(500);
// navigate to General tab
await page.getByRole('tab', { name: 'General' }).click();
// get the current default location and compute a different valid path
const defaultLocationInput = page.locator('.default-location-input');
const currentValue = await defaultLocationInput.inputValue();
// Use parent directory as alternate path (guaranteed to exist and differ)
const alternateExistingPath = currentValue.split('/').slice(0, -1).join('/');
// set a different default location (readonly input, remove readonly then fill)
await defaultLocationInput.evaluate((el) => {
const input = el;
input.removeAttribute('readonly');
input.readOnly = false;
});
await defaultLocationInput.fill(alternateExistingPath);
// wait for auto-save to complete (debounce is 500ms)
await page.waitForTimeout(1000);
// close preferences tab
await page.locator('.preferences-button').click();
await page.waitForTimeout(300);
// reopen preferences and verify persistence
await page.locator('.preferences-button').click();
await page.waitForTimeout(500);
await page.getByRole('tab', { name: 'General' }).click();
const savedValue = await page.locator('.default-location-input').inputValue();
expect(savedValue).toBe(alternateExistingPath);
});
test('Should use default location in Create Collection modal', async ({ pageWithUserData: page }) => {
// test Create Collection modal
await page.getByTestId('collections-header-add-menu').click();
await page.locator('.tippy-box .dropdown-item').filter({ hasText: 'Create collection' }).click();
// Wait for inline creator to appear, then click the cog button to open advanced modal
const inlineCreator = page.locator('.inline-collection-creator');
await inlineCreator.waitFor({ state: 'visible', timeout: 5000 });
await inlineCreator.locator('.cog-btn').click();
// Wait for modal to be visible
await page.locator('.bruno-modal').waitFor({ state: 'visible' });
// verify the default location is pre-filled
// Scope to the modal to avoid conflict with preferences tab
const collectionLocationInput = page.locator('.bruno-modal').getByLabel('Location', { exact: true });
await expect(collectionLocationInput).toBeVisible();
const inputValue = await collectionLocationInput.inputValue();
expect(inputValue.endsWith(EXPECTED_PATH_SUFFIX)).toBe(true);
// cancel the collection creation
await page.locator('.bruno-modal').getByRole('button', { name: 'Cancel' }).click();
});
test('Should use default location in Clone Collection modal', async ({ pageWithUserData: page }) => {
// open the clone collection modal
const collection = page.locator('.collection-name').first();
await collection.hover();
await collection.locator('.collection-actions .icon').click();
await page.locator('.dropdown-item').filter({ hasText: 'Clone' }).click();
// Wait for modal to be visible
await page.locator('.bruno-modal').waitFor({ state: 'visible' });
// verify the default location is pre-filled
// Scope to the modal to avoid conflict with preferences tab
const cloneLocationInput = page.locator('.bruno-modal').getByLabel('Location', { exact: true });
await expect(cloneLocationInput).toBeVisible();
const cloneValue = await cloneLocationInput.inputValue();
expect(cloneValue.endsWith(EXPECTED_PATH_SUFFIX)).toBe(true);
// cancel the clone operation
await page.locator('.bruno-modal').getByRole('button', { name: 'Cancel' }).click();
});
test('Should save empty default location', async ({ pageWithUserData: page }) => {
// open preferences tab
await page.locator('.preferences-button').click();
// wait for preferences tab to be visible
await page.waitForTimeout(500);
// navigate to General tab
await page.getByRole('tab', { name: 'General' }).click();
// clear the default location field (readonly input, remove readonly then clear)
const defaultLocationInput = page.locator('.default-location-input');
await defaultLocationInput.evaluate((el) => {
const input = el;
input.removeAttribute('readonly');
input.readOnly = false;
});
await defaultLocationInput.clear();
// wait for auto-save to complete (debounce is 500ms)
await page.waitForTimeout(1000);
});
});