mirror of
https://github.com/usebruno/bruno.git
synced 2026-06-11 09:51:30 +00:00
* refactor: enhance error handling and context retrieval for script errors - Updated the error formatter to utilize in-memory script content for error context, improving accuracy when users have unsaved changes. - Introduced a new utility function, `getSourceContextFromContent`, to extract context lines from in-memory scripts. - Enhanced tests to verify that draft script errors display the correct code context, ensuring users see the most relevant information during debugging. - Added new Playwright tests to validate error handling in draft states across pre-request, post-response, and test scripts. * refactor: enhance error context retrieval in error formatter - Updated `getSourceContext` to accept in-memory content, improving context extraction for unsaved changes. - Deprecated `getSourceContextFromContent` in favor of the new parameterized approach. - Adjusted related tests to ensure accurate context handling for draft script errors. * refactor: enhance error context handling for draft scripts * refactor: streamline script error tests and enhance utility functions - Consolidated helper functions for sending requests and waiting for responses into the actions module. - Introduced new utility functions for selecting script sub-tabs and editing CodeMirror editors. - Updated test cases to utilize the new utility functions, improving readability and maintainability. - Enhanced locators for better integration with testing frameworks. * refactor: improve script error context handling and utility functions - Introduced a new utility function to streamline the retrieval of script block start lines for .bru and .yml files. - Enhanced the error formatter to prioritize in-memory draft content when resolving error contexts, improving accuracy for unsaved changes. - Consolidated context extraction logic into a single function to reduce redundancy and improve maintainability. - Updated related tests to ensure accurate context handling for both draft and disk-based scripts. * refactor: add comments to clarify line index calculations in error formatter
121 lines
4.9 KiB
TypeScript
121 lines
4.9 KiB
TypeScript
import { test, expect } from '../../playwright';
|
|
import { buildScriptErrorLocators, buildCommonLocators } from '../utils/page/locators';
|
|
import {
|
|
openRequest,
|
|
selectRequestPaneTab,
|
|
selectScriptSubTab,
|
|
editCodeMirrorEditor,
|
|
sendAndWaitForErrorCard,
|
|
sendAndWaitForResponse
|
|
} from '../utils/page/actions';
|
|
import { setSandboxMode } from '../utils/page/runner';
|
|
|
|
for (const mode of ['safe', 'developer'] as const) {
|
|
test.describe.serial(`Draft Script Error Context [${mode} mode]`, () => {
|
|
let scriptErrorLocators: ReturnType<typeof buildScriptErrorLocators>;
|
|
let commonLocators: ReturnType<typeof buildCommonLocators>;
|
|
|
|
test.beforeAll(async ({ pageWithUserData: page }) => {
|
|
scriptErrorLocators = buildScriptErrorLocators(page);
|
|
commonLocators = buildCommonLocators(page);
|
|
|
|
await setSandboxMode(page, 'script-errors-test', mode);
|
|
});
|
|
|
|
test('1. Draft pre-request error shows draft code in error context', async ({ pageWithUserData: page }) => {
|
|
await test.step('Open draft-error-test request', async () => {
|
|
await openRequest(page, 'script-errors-test', 'draft-error-test');
|
|
});
|
|
|
|
await test.step('Navigate to Script > Pre Request tab and edit script', async () => {
|
|
await selectScriptSubTab(page, 'pre-request');
|
|
|
|
await editCodeMirrorEditor(
|
|
page,
|
|
'pre-request-script-editor',
|
|
'const draftOnlyVar = "draft";\ndraftOnlyUndefined();'
|
|
);
|
|
});
|
|
|
|
await test.step('Verify draft indicator is visible', async () => {
|
|
await expect(commonLocators.tabs.draftIndicator()).toBeVisible({ timeout: 5000 });
|
|
});
|
|
|
|
await test.step('Send request and wait for error card', async () => {
|
|
await sendAndWaitForErrorCard(page);
|
|
});
|
|
|
|
await test.step('Verify error card shows draft code, not saved code', async () => {
|
|
const card = scriptErrorLocators.card();
|
|
await expect(scriptErrorLocators.title(card)).toContainText('Pre-Request Script Error');
|
|
await expect(scriptErrorLocators.errorLine(card)).toContainText('draftOnlyUndefined');
|
|
await expect(scriptErrorLocators.errorLine(card)).not.toContainText('savedVar');
|
|
});
|
|
});
|
|
|
|
test('2. Draft post-response error shows draft code in error context', async ({ pageWithUserData: page }) => {
|
|
await test.step('Open draft-postres-test request', async () => {
|
|
await openRequest(page, 'script-errors-test', 'draft-postres-test');
|
|
});
|
|
|
|
await test.step('Navigate to Script > Post Response tab and edit script', async () => {
|
|
await selectScriptSubTab(page, 'post-response');
|
|
|
|
await editCodeMirrorEditor(
|
|
page,
|
|
'post-response-script-editor',
|
|
'const postDraftVar = "post-draft";\npostDraftUndefined();'
|
|
);
|
|
});
|
|
|
|
await test.step('Verify draft indicator is visible', async () => {
|
|
await expect(commonLocators.tabs.draftIndicator()).toBeVisible({ timeout: 5000 });
|
|
});
|
|
|
|
await test.step('Send request and wait for error card', async () => {
|
|
await sendAndWaitForResponse(page);
|
|
});
|
|
|
|
await test.step('Verify error card shows draft code, not saved code', async () => {
|
|
const card = scriptErrorLocators.card();
|
|
await expect(card).toBeVisible();
|
|
await expect(scriptErrorLocators.title(card)).toContainText('Post-Response Script Error');
|
|
await expect(scriptErrorLocators.errorLine(card)).toContainText('postDraftUndefined');
|
|
await expect(scriptErrorLocators.errorLine(card)).not.toContainText('savedData');
|
|
});
|
|
});
|
|
|
|
test('3. Draft test script error shows draft code in error context', async ({ pageWithUserData: page }) => {
|
|
await test.step('Open draft-tests-test request', async () => {
|
|
await openRequest(page, 'script-errors-test', 'draft-tests-test');
|
|
});
|
|
|
|
await test.step('Navigate to Tests tab and edit script', async () => {
|
|
await selectRequestPaneTab(page, 'Tests');
|
|
|
|
await editCodeMirrorEditor(
|
|
page,
|
|
'test-script-editor',
|
|
'const draftTest = "test";\ndraftTestUndefined();'
|
|
);
|
|
});
|
|
|
|
await test.step('Verify draft indicator is visible', async () => {
|
|
await expect(commonLocators.tabs.draftIndicator()).toBeVisible({ timeout: 5000 });
|
|
});
|
|
|
|
await test.step('Send request and wait for response', async () => {
|
|
await sendAndWaitForResponse(page);
|
|
});
|
|
|
|
await test.step('Verify error card shows draft code, not saved code', async () => {
|
|
const card = scriptErrorLocators.card();
|
|
await expect(card).toBeVisible();
|
|
await expect(scriptErrorLocators.title(card)).toContainText('Test Script Error');
|
|
await expect(scriptErrorLocators.errorLine(card)).toContainText('draftTestUndefined');
|
|
await expect(scriptErrorLocators.errorLine(card)).not.toContainText('savedTest');
|
|
});
|
|
});
|
|
});
|
|
}
|