diff --git a/packages/bruno-app/src/components/Environments/EnvironmentSelector/index.js b/packages/bruno-app/src/components/Environments/EnvironmentSelector/index.js index e88406597..1defe9bbf 100644 --- a/packages/bruno-app/src/components/Environments/EnvironmentSelector/index.js +++ b/packages/bruno-app/src/components/Environments/EnvironmentSelector/index.js @@ -193,7 +193,7 @@ const EnvironmentSelector = ({ collection }) => { {/* Modals - Rendered outside dropdown to avoid conflicts */} {showGlobalSettings && ( - + )} {showCollectionSettings && } diff --git a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js index d91e2eb1c..c16dbc9d9 100644 --- a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js +++ b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js @@ -2,7 +2,7 @@ import React, { useRef, useEffect } from 'react'; import cloneDeep from 'lodash/cloneDeep'; import { IconTrash, IconAlertCircle } from '@tabler/icons'; import { useTheme } from 'providers/Theme'; -import { useDispatch } from 'react-redux'; +import { useDispatch, useSelector } from 'react-redux'; import MultiLineEditor from 'components/MultiLineEditor/index'; import StyledWrapper from './StyledWrapper'; import { uuid } from 'utils/common'; @@ -12,11 +12,18 @@ import { variableNameRegex } from 'utils/common/regex'; import toast from 'react-hot-toast'; import { saveGlobalEnvironment } from 'providers/ReduxStore/slices/global-environments'; import { Tooltip } from 'react-tooltip'; +import { getGlobalEnvironmentVariables } from 'utils/collections'; -const EnvironmentVariables = ({ environment, setIsModified, originalEnvironmentVariables }) => { +const EnvironmentVariables = ({ environment, setIsModified, originalEnvironmentVariables, collection }) => { const dispatch = useDispatch(); const { storedTheme } = useTheme(); const addButtonRef = useRef(null); + const { globalEnvironments, activeGlobalEnvironmentUid } = useSelector(state => state.globalEnvironments); + + let _collection = cloneDeep(collection); + + const globalEnvironmentVariables = getGlobalEnvironmentVariables({ globalEnvironments, activeGlobalEnvironmentUid }); + _collection.globalEnvironmentVariables = globalEnvironmentVariables; const formik = useFormik({ enableReinitialize: true, @@ -93,7 +100,7 @@ const EnvironmentVariables = ({ environment, setIsModified, originalEnvironmentV useEffect(() => { if (formik.dirty) { - // Smooth scrolling to the changed parameter is temporarily disabled + // Smooth scrolling to the changed parameter is temporarily disabled // due to UX issues when editing the first row in a long list of environment variables. // addButtonRef.current?.scrollIntoView({ behavior: 'smooth' }); } @@ -149,7 +156,7 @@ const EnvironmentVariables = ({ environment, setIsModified, originalEnvironmentV
{ +const EnvironmentDetails = ({ environment, setIsModified, collection }) => { const [openEditModal, setOpenEditModal] = useState(false); const [openDeleteModal, setOpenDeleteModal] = useState(false); const [openCopyModal, setOpenCopyModal] = useState(false); @@ -37,7 +37,7 @@ const EnvironmentDetails = ({ environment, setIsModified }) => {
- +
); diff --git a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/index.js b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/index.js index d04edd838..c99459efe 100644 --- a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/index.js +++ b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/EnvironmentList/index.js @@ -10,7 +10,7 @@ import ImportEnvironment from '../ImportEnvironment'; import { isEqual } from 'lodash'; import ToolHint from 'components/ToolHint/index'; -const EnvironmentList = ({ environments, activeEnvironmentUid, selectedEnvironment, setSelectedEnvironment, isModified, setIsModified }) => { +const EnvironmentList = ({ environments, activeEnvironmentUid, selectedEnvironment, setSelectedEnvironment, isModified, setIsModified, collection }) => { const [openCreateModal, setOpenCreateModal] = useState(false); const [openImportModal, setOpenImportModal] = useState(false); const [openManageSecretsModal, setOpenManageSecretsModal] = useState(false); @@ -143,6 +143,7 @@ const EnvironmentList = ({ environments, activeEnvironmentUid, selectedEnvironme environment={selectedEnvironment} setIsModified={setIsModified} originalEnvironmentVariables={originalEnvironmentVariables} + collection={collection} /> diff --git a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/index.js b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/index.js index 3af5570b4..d3e8d16d8 100644 --- a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/index.js +++ b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/index.js @@ -39,7 +39,7 @@ const DefaultTab = ({ setTab }) => { ); }; -const EnvironmentSettings = ({ globalEnvironments, onClose }) => { +const EnvironmentSettings = ({ globalEnvironments, collection, onClose }) => { const [isModified, setIsModified] = useState(false); const environments = globalEnvironments; const [selectedEnvironment, setSelectedEnvironment] = useState(null); @@ -68,6 +68,7 @@ const EnvironmentSettings = ({ globalEnvironments, onClose }) => { setSelectedEnvironment={setSelectedEnvironment} isModified={isModified} setIsModified={setIsModified} + collection={collection} /> );