rayan/bruno
1
0
Fork 0
mirror of https://github.com/usebruno/bruno.git synced 2026-07-07 22:18:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: enhance environment variable persistence handling (#5783)

Browse Source 
* feat: enhance environment variable persistence handling

* feat: experiment playwright with multiple workers

---------

Co-authored-by: Bijin Bruno <bijin@usebruno.com>
This commit is contained in:
Sanjai Kumar
2025-10-25 19:02:45 +05:30
committed by GitHub
parent a538b27f24
commit c5325c732f
18 changed files with 209 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
View File

@@ -1467,8 +1467,16 @@ export const mergeAndPersistEnvironment =
}
});
// Save only non-ephemeral vars, or ephemerals explicitly persisted this run
// Save all non-ephemeral vars and all variables that were previously persisted
const persistedNames = new Set(Object.keys(persistentEnvVariables));
// Add all existing non-ephemeral variables to persistedNames so they are preserved
existingVars.forEach((v) => {
if (!v.ephemeral) {
persistedNames.add(v.name);
}
});
const environmentToSave = cloneDeep(environment);
environmentToSave.variables = buildPersistedEnvVariables(merged, { mode: 'merge', persistedNames });

9
packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
View File

@@ -316,7 +316,7 @@ export const collectionsSlice = createSlice({
}
},
scriptEnvironmentUpdateEvent: (state, action) => {
const { collectionUid, envVariables, runtimeVariables } = action.payload;
const { collectionUid, envVariables, runtimeVariables, persistentEnvVariables } = action.payload;
const collection = findCollectionByUid(state.collections, collectionUid);
if (collection) {
@@ -326,9 +326,10 @@ export const collectionsSlice = createSlice({
if (activeEnvironment) {
forOwn(envVariables, (value, key) => {
const variable = find(activeEnvironment.variables, (v) => v.name === key);
const isPersistent = persistentEnvVariables && persistentEnvVariables[key] !== undefined;
if (variable) {
// For updates coming from scripts, treat them as ephemeral overlays.
// For updates coming from scripts, treat them as ephemeral overlays unless they are persistent.
if (variable.value !== value) {
/*
Overlay (persist: false): keep new value in Redux for UI and mark ephemeral
@@ -337,7 +338,7 @@ export const collectionsSlice = createSlice({
*/
const previousValue = variable.value;
variable.value = value;
variable.ephemeral = true;
variable.ephemeral = !isPersistent;
if (variable.persistedValue === undefined) {
variable.persistedValue = previousValue;
}
@@ -353,7 +354,7 @@ export const collectionsSlice = createSlice({
enabled: true,
type: 'text',
uid: uuid(),
ephemeral: true,
ephemeral: !isPersistent
});
}
}

3
packages/bruno-electron/src/ipc/network/index.js
View File

@@ -398,6 +398,7 @@ const registerNetworkIpc = (mainWindow) => {
mainWindow.webContents.send('main:script-environment-update', {
envVariables: scriptResult.envVariables,
runtimeVariables: scriptResult.runtimeVariables,
persistentEnvVariables: scriptResult.persistentEnvVariables,
requestUid,
collectionUid
});
@@ -486,6 +487,7 @@ const registerNetworkIpc = (mainWindow) => {
mainWindow.webContents.send('main:script-environment-update', {
envVariables: result.envVariables,
runtimeVariables: result.runtimeVariables,
persistentEnvVariables: result.persistentEnvVariables,
requestUid,
collectionUid
});
@@ -532,6 +534,7 @@ const registerNetworkIpc = (mainWindow) => {
mainWindow.webContents.send('main:script-environment-update', {
envVariables: scriptResult.envVariables,
runtimeVariables: scriptResult.runtimeVariables,
persistentEnvVariables: scriptResult.persistentEnvVariables,
requestUid,
collectionUid
});