From b188a9e9a9efae5e804fa3a125b6fb2b2114ca67 Mon Sep 17 00:00:00 2001 From: sanish chirayath Date: Thu, 18 Dec 2025 19:37:33 +0530 Subject: [PATCH] fix: unable to add assertions to a request (#6435) * fix: add assertion * rm: unnecessary wait fn * fix: test * fix: tests * fix: review comments * fix: review * fix: review comments * fix: review comments * fix: test failure * review fixes * fix: rm sandbox accept * fix: indentation --- .../src/components/EditableTable/index.js | 13 +- .../Assertions/AssertionOperator/index.js | 2 +- .../RequestPane/Assertions/index.js | 1 + .../bruno-schema/src/collections/index.js | 46 ++- tests/asserts/add-assertions.spec.ts | 279 ++++++++++++++++++ tests/asserts/fixtures/collection/bruno.json | 6 + .../collection/environments/Local.bru | 3 + tests/asserts/fixtures/collection/ping.bru | 11 + tests/asserts/init-user-data/preferences.json | 5 + tests/utils/page/actions.ts | 145 ++++++++- tests/utils/page/locators.ts | 45 +++ 11 files changed, 546 insertions(+), 10 deletions(-) create mode 100644 tests/asserts/add-assertions.spec.ts create mode 100644 tests/asserts/fixtures/collection/bruno.json create mode 100644 tests/asserts/fixtures/collection/environments/Local.bru create mode 100644 tests/asserts/fixtures/collection/ping.bru create mode 100644 tests/asserts/init-user-data/preferences.json diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js index 5fcf171b3..3e3bd29f5 100644 --- a/packages/bruno-app/src/components/EditableTable/index.js +++ b/packages/bruno-app/src/components/EditableTable/index.js @@ -16,7 +16,8 @@ const EditableTable = ({ checkboxKey = 'enabled', reorderable = false, onReorder, - showAddRow = true + showAddRow = true, + testId = 'editable-table' }) => { const tableRef = useRef(null); const emptyRowUidRef = useRef(null); @@ -224,7 +225,7 @@ const EditableTable = ({ return ( -
+
@@ -285,6 +286,7 @@ const EditableTable = ({ handleCheckboxChange(row.uid, e.target.checked)} /> @@ -292,14 +294,17 @@ const EditableTable = ({ )} {columns.map((column) => ( - ))} {showDelete && (
+ {renderCell(column, row, rowIndex)} {!isEmpty && ( - )} diff --git a/packages/bruno-app/src/components/RequestPane/Assertions/AssertionOperator/index.js b/packages/bruno-app/src/components/RequestPane/Assertions/AssertionOperator/index.js index 523fcf73d..2da941b0e 100644 --- a/packages/bruno-app/src/components/RequestPane/Assertions/AssertionOperator/index.js +++ b/packages/bruno-app/src/components/RequestPane/Assertions/AssertionOperator/index.js @@ -81,7 +81,7 @@ const AssertionOperator = ({ operator, onChange }) => { }; return ( - {operators.map((operator) => (