From 87f74262bb7e535f3c73b97ec3fe99205252e82d Mon Sep 17 00:00:00 2001 From: sanish chirayath Date: Fri, 26 Jun 2026 23:01:37 +0530 Subject: [PATCH] feat(variables): persist scripted variable changes by default + re-enable disabled scripting APIs (#8315) * feat(variables): add variable persistence with scripting feat(collections): implement script-driven update for collection variables, ensuring direct root modification and draft synchronization feat(collections): enhance script variable management with baseline tracking and draft preservation * feat(variables): add runtime variable updates and optimize disk writes by implementing dirty flags fix(collections): handle errors during environment persistence in script execution feat(collections): implement baseline clearing for script execution and optimize variable update handling feat(tests): add default persistence tests for environment variables and update runtime variable handling refactor(collections): streamline variable update handling and improve draft management by removing redundant comments and optimizing code clarity test(collection-vars): add verification for draft edits and script variable visibility in collection settings UI refactor(collection-vars): update header value selection logic for improved clarity and accuracy in draft isolation tests * feat(global-environments): enhance global environment updates to resolve stale active UIDs and improve persistence logic - Updated the `updateGlobalEnvironments` reducer to handle stale active UIDs by matching against environment names. - Improved the logic for setting global environments and active UIDs to ensure consistency after disk reloads. - Removed outdated tests related to persisted values in favor of more relevant assertions for environment variable handling. * feat(variables): enhance typed value handling and persistence in global and collection environments - Added tests to infer data types (number, boolean, object) when setting environment and collection variables. - Updated the logic to preserve existing data types when variables are not modified by scripts. - Implemented dirty flags to track changes in typed variables, ensuring accurate persistence across sessions. - Refactored related tests to verify the correct behavior of typed variables in various scenarios. * refactor(variables): streamline data type inference and enhance deletion methods - Removed redundant data type inference logic from global and collection variable updates to simplify the codebase. - Updated deletion methods in the Bru class to use Object.keys for improved resilience against user-defined properties. - Added tests to ensure deletion methods function correctly even when properties are shadowed. - Enhanced clarity in draft merge tests by standardizing keyboard shortcuts for selecting all text. * fix(tests): correct variable naming and improve environment panel interactions - Updated test cases to reflect the correct variable name 'wasSaved' instead of 'was-saved'. - Modified environment panel interaction to remove forced click, enhancing test reliability. - Added a utility function to close the environment panel in safe mode tests for better readability and maintainability. * feat(runtime): enhance variable management and cleanup logic - Introduced a new method to clear script-driven variable baselines for collections, ensuring no stale data leaks into new requests. - Updated the handling of runtime variables in the Bru class to track changes with a new dirty flag, improving state management. - Refactored the application of script environment variables to prevent direct mutations, ensuring immutability and cleaner state updates. - Enhanced the response handling in the script runtime to conditionally include runtime variables based on their dirty state. * feat(variables): improve request handling and state management for collections and environments - Enhanced event listeners to clear global environment baselines on both 'testrun-started' and 'request-queued' events, preventing stale data issues. - Updated global environment and collection variable update events to ignore stale updates from superseded requests, ensuring accurate state management. - Refactored the Bru class to optimize variable management, including checks for existing keys before updates and deletions, improving performance and reliability. - Introduced request UID tracking to maintain consistency across variable updates during concurrent requests. * refactor(collections): update action to clear script variable baselines - Replaced the dispatch of `_clearScriptGlobalEnvBaseline` with `clearScriptVariableBaselines` to improve clarity and maintainability in the Redux action handling for collections. * feat(environments): introduce getScriptModifiedKeys utility for improved variable management - Added a new utility function, `getScriptModifiedKeys`, to identify keys modified by scripts relative to a baseline, enhancing the handling of data types during variable updates. - Updated the application of script environment variables to prevent overwriting user-defined draft changes during no-op writes. - Refactored related logic in collections and global environments to utilize the new utility, ensuring accurate state management and improved clarity in the Redux slices. * refactor(global-environments): simplify active UID resolution logic in updateGlobalEnvironments reducer - Streamlined the logic for resolving the active global environment UID by consolidating conditions into a more concise format. - Removed outdated comments to enhance code clarity and maintainability. - Updated tests to ensure accurate resolution of active UIDs based on incoming environment data. * refactor(tests): remove outdated comments and streamline environment variable row expectations - Eliminated comments related to state sync and inference issues to enhance code clarity. - Adjusted expectations for environment variable row rendering in tests, focusing on relevant assertions. * feat(tests): add comprehensive tests for secret variable persistence in environments - Introduced new test cases to validate the preservation of secret variables when updated via scripts in both collection and global environments. - Implemented tests to ensure that secret values are encrypted before storage and can be correctly decrypted for subsequent requests. - Added fixtures and environment configurations for testing secret variable behavior in both bru and yml formats. - Enhanced utility functions for managing environment configurations and interactions within the test suite. * feat(tests): enhance environment variable tests and add global variable persistence - Updated MultiLineEditor and SingleLineEditor components to include data-testid for secret reveal toggle buttons, improving testability. - Introduced new tests for global environment variable persistence, ensuring non-secret variables survive app restarts and are correctly interpolated. - Added fixtures for workspace and collections to support the new global variable tests, enhancing the overall test coverage for environment management. - Refactored utility functions to streamline interactions with environment variables in tests. * refactor(collections): optimize environment and collection saving logic - Simplified the persistence logic for active environments by directly constructing the environment copy, reducing unnecessary cloning. - Updated the collection saving process to utilize the fresh collection state, ensuring accurate data is saved without drafts. - Enhanced error handling during the save operations to improve reliability and maintainability. * feat(tests): implement collection variable persistence tests - Added multiple test cases to validate the persistence of collection variables across app restarts, including typed values and multiple variable settings. - Created new fixtures for collection variables to support the tests, ensuring accurate simulation of variable management scenarios. - Enhanced the existing collection management logic to ensure that variables are correctly set and deleted as per the test requirements. * feat(tests): add tests for typed global environment variable persistence - Introduced a new test suite to validate the persistence of typed global environment variables across app restarts, ensuring correct data types are maintained. - Created a fixture for the test collection to simulate setting global variables with various data types, including number, boolean, object, and string. - Enhanced the test logic to verify that the environment file reflects the correct state before and after application restarts. * fix(tests): update request tab close interaction in variable persistence tests * fix(tests): improve hover interaction for collection actions in runner tests - Updated the hover logic for revealing collection actions to handle sidebar re-renders more reliably. - Replaced one-shot hover with a polling mechanism to ensure visibility of actions, enhancing test stability. * refactor(environments): streamline environment variable handling and remove ephemeral metadata logic - Simplified the comparison logic for environment variables by removing unnecessary ephemeral metadata handling. - Updated the saving process to directly use the environment variables without stripping metadata, enhancing clarity and maintainability. - Removed outdated comments and unused utility functions related to ephemeral variables, improving code cleanliness. * fix(ipc): update persistActiveEnvironment to handle requestUid for stale updates - Modified the persistActiveEnvironment function to accept a requestUid parameter, allowing for better management of stale updates. - Enhanced the logic to prevent disk writes for superseded requests, improving data integrity during environment persistence. * refactor(bru): remove unused envName variable in deleteAllEnvVars method - Eliminated the envName variable from the deleteAllEnvVars method, simplifying the logic for deleting environment variables. - Cleaned up the method by removing unnecessary checks related to the envName, enhancing code clarity and maintainability. * fix(bru): prevent deletion of internal __name__ variable in deleteEnvVar method - Added a check in the deleteEnvVar method to silently ignore attempts to delete the internal __name__ variable, preserving its integrity. - Updated tests to verify that the __name__ variable remains unchanged when deleteEnvVar is called with this key. - Enhanced runtime tests to ensure compatibility with QuickJS by confirming that environment variables set with persist options are handled correctly. * feat(tests): add legacy support test for environment variable persistence - Introduced a new test suite to validate that the legacy argument for setting environment variables with persistence is still functional in version 4. - Created a fixture to simulate the legacy syntax, ensuring that the variable is correctly persisted on disk without errors. - Enhanced integration testing to confirm that the legacy behavior aligns with the current implementation, maintaining backward compatibility. * test(tests): enhance legacy environment variable persistence tests for safe and developer modes - Updated the test suite for `bru.setEnvVar` to verify that the legacy persist flag is correctly handled in both safe and developer modes. - Introduced a helper function to streamline the verification process and ensure consistent behavior across different execution contexts. - Adjusted the test logic to reset the environment state between mode switches, maintaining test integrity. - Improved hover interaction in multiple persistent variable tests to ensure reliable visibility of actions during execution. * fix(EnvironmentVariablesTable): correct change detection logic for environment variables - Updated the logic for determining changes in environment variables to compare active current and saved values instead of previously used variablesToSave and savedValues. - This change ensures accurate detection of modifications before saving, improving user feedback when no changes are present. * test(tests): enhance secret variable persistence tests for environment configurations - Updated the test suites for `bru.setEnvVar` and `bru.setGlobalEnvVar` to include interactions with the secrets tab, ensuring visibility of secret variables during various states of the environment. - Added checks to confirm that the eye toggle functionality correctly reveals the values of secret variables after setting and overwriting them. - Improved test coverage for secret variable persistence, validating that the expected values are displayed in both collection and global environment contexts. --- .../EnvironmentVariablesTable/index.js | 18 +- .../ConfirmCloseEnvironment/index.js | 6 +- .../src/components/MultiLineEditor/index.js | 2 +- .../src/components/SingleLineEditor/index.js | 2 +- .../src/providers/App/useIpcEvents.js | 29 +- .../ReduxStore/slices/collections/actions.js | 182 ++--- .../draft-collection-vars-isolation.spec.js | 465 +++++++++++++ .../draft-collection-vars-merge.spec.js | 638 ++++++++++++++++++ .../collections/draft-env-merge.spec.js | 627 +++++++++++++++++ .../ReduxStore/slices/collections/index.js | 200 +++--- .../slices/collections/index.spec.js | 100 +-- .../ReduxStore/slices/global-environments.js | 137 ++-- .../slices/global-environments.spec.js | 531 +++++++++++++++ .../src/utils/codemirror/autocomplete.js | 16 +- .../bruno-app/src/utils/collections/index.js | 7 +- packages/bruno-app/src/utils/environments.js | 108 ++- .../bruno-app/src/utils/environments.spec.js | 292 ++++++-- .../src/ipc/ai/script-prompts.js | 1 - packages/bruno-electron/src/ipc/collection.js | 7 +- .../bruno-electron/src/ipc/network/index.js | 147 ++-- .../tests/store/env-secrets.spec.js | 62 ++ packages/bruno-js/src/bru.js | 168 ++--- .../bruno-js/src/runtime/script-runtime.js | 16 +- packages/bruno-js/src/runtime/test-runtime.js | 15 +- packages/bruno-js/src/runtime/vars-runtime.js | 8 +- .../bruno-js/src/sandbox/quickjs/shims/bru.js | 76 +-- packages/bruno-js/tests/collectionVar.spec.js | 217 ++++++ packages/bruno-js/tests/globalEnvVar.spec.js | 207 ++++++ packages/bruno-js/tests/runtime.spec.js | 138 ++-- packages/bruno-js/tests/setEnvVar.spec.js | 312 ++++++--- packages/bruno-tests/collection/ping.bru | 2 +- .../api/bru/deleteAllCollectionVars.bru | 9 +- .../scripting/api/bru/deleteAllEnvVars.bru | 6 + .../api/bru/deleteAllGlobalEnvVars.bru | 9 +- .../scripting/api/bru/deleteCollectionVar.bru | 12 +- .../scripting/api/bru/deleteEnvVar.bru | 32 + .../scripting/api/bru/deleteGlobalEnvVar.bru | 12 +- .../api/bru/getAllCollectionVars.bru | 3 - .../scripting/api/bru/setCollectionVar.bru | 5 - .../scripting/api/bru/setGlobalEnvVar.bru | 28 + .../api-deleteCollectionVar.spec.ts | 66 ++ ...tCollectionVar-default-persistence.spec.ts | 49 ++ .../api-setCollectionVar-typed.spec.ts | 78 +++ .../collection/api-deleteCollectionVar.bru | 16 + .../api-multi-persist-coll-vars.bru | 21 + ...i-setCollectionVar-default-persistence.bru | 15 + .../collection/api-setCollectionVar-typed.bru | 21 + .../fixtures/collection/bruno.json | 5 + .../fixtures/collection/collection.bru | 8 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../multiple-persist-vars.spec.ts | 51 ++ .../api-setEnvVar-secret.spec.ts | 351 ++++++++++ .../fixtures/collections/bru/bruno.json | 9 + .../collections/bru/environments/Local.bru | 6 + .../fixtures/collections/bru/read-secret.bru | 11 + .../fixtures/collections/bru/seed-secret.bru | 15 + .../fixtures/collections/bru/set-secret.bru | 15 + .../collections/yml/environments/Local.yml | 6 + .../collections/yml/opencollection.yml | 3 + .../fixtures/collections/yml/read-secret.yml | 8 + .../fixtures/collections/yml/seed-secret.yml | 14 + .../fixtures/collections/yml/set-secret.yml | 14 + .../init-user-data/collection-security.json | 16 + .../init-user-data/preferences.json | 6 + .../api-setEnvVar-with-persist.spec.ts | 91 ++- .../api-setEnvVar-without-persist.spec.ts | 60 -- .../api-setEnvVar/api-setEnvVar.spec.ts | 82 +++ .../collection/api-setEnvVar-with-persist.bru | 6 +- ...-without-persist.bru => api-setEnvVar.bru} | 2 +- .../multiple-persist-vars-1.bru | 2 +- .../multiple-persist-vars-2.bru | 2 +- .../multiple-persist-vars.spec.ts | 12 +- .../api-setGlobalEnvVar-secret.spec.ts | 305 +++++++++ .../collections/test-collection/bruno.json | 9 + .../test-collection/read-global-secret.bru | 11 + .../test-collection/seed-global-secret.bru | 15 + .../test-collection/set-global-secret.bru | 15 + .../fixtures/workspace/environments/Local.yml | 10 + .../fixtures/workspace/workspace.yml | 12 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 7 + .../api-setGlobalEnvVar-restart.spec.ts | 86 +++ .../api-setGlobalEnvVar-typed-restart.spec.ts | 101 +++ .../collections/test-collection/bruno.json | 9 + .../test-collection/read-global-var.bru | 11 + .../test-collection/set-global-var.bru | 15 + .../test-collection/set-typed-global-vars.bru | 20 + .../fixtures/workspace/environments/Local.yml | 10 + .../fixtures/workspace/workspace.yml | 12 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 7 + ...ction-vars-draft-merge-with-script.spec.ts | 62 ++ .../bruno.json | 9 + .../collection.bru | 4 + .../environments/Test.bru | 3 + .../set-collection-var.bru | 22 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../datatype-preservation.spec.ts | 11 + .../draft-merge-with-script.spec.ts | 55 ++ .../collections/draft-merge-test/bruno.json | 9 + .../draft-merge-test/environments/Test.bru | 4 + .../draft-merge-test/set-env-var.bru | 22 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../global-env-draft-merge-test/bruno.json | 9 + .../set-global-env-var.bru | 22 + ...global-env-draft-merge-with-script.spec.ts | 48 ++ .../init-user-data/collection-security.json | 10 + .../init-user-data/global-environments.json | 27 + .../init-user-data/preferences.json | 5 + .../global-env-update-via-script.spec.ts | 57 +- .../collection-vars-draft-isolation.spec.ts | 64 ++ .../draft-isolation-test/bruno.json | 9 + .../draft-isolation-test/collection.bru | 7 + .../environments/Test.bru | 3 + .../set-collection-var.bru | 22 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../bruno.json | 9 + .../set-typed-global-env-vars.bru | 25 + .../global-env-var-persistence-typed.spec.ts | 54 ++ .../init-user-data/collection-security.json | 10 + .../init-user-data/global-environments.json | 19 + .../init-user-data/preferences.json | 5 + .../bruno.json | 9 + .../delete-global-env-var.bru | 22 + .../set-global-env-var.bru | 22 + .../global-env-var-persistence.spec.ts | 66 ++ .../init-user-data/collection-security.json | 10 + .../init-user-data/global-environments.json | 27 + .../init-user-data/preferences.json | 5 + .../bruno.json | 9 + .../environments/Test.bru | 3 + .../req-1-write.bru | 21 + .../req-2-read-and-write.bru | 29 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + ...variable-persistence-multi-request.spec.ts | 42 ++ .../variable-persistence-safe-test/bruno.json | 9 + .../environments/Test.bru | 3 + .../set-collection-var.bru | 22 + .../set-env-var.bru | 22 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../variable-persistence-safe-mode.spec.ts | 52 ++ .../bruno.json | 9 + .../environments/Test.bru | 3 + .../set-typed-collection-vars.bru | 25 + .../set-typed-env-vars.bru | 25 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + ...riable-persistence-typed-safe-mode.spec.ts | 75 ++ .../bruno.json | 9 + .../environments/Test.bru | 3 + .../set-typed-collection-vars.bru | 25 + .../set-typed-env-vars.bru | 25 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../variable-persistence-typed.spec.ts | 74 ++ .../variable-persistence-test/bruno.json | 9 + .../environments/Test.bru | 3 + .../set-collection-var.bru | 22 + .../variable-persistence-test/set-env-var.bru | 22 + .../init-user-data/collection-security.json | 10 + .../init-user-data/preferences.json | 5 + .../variable-persistence.spec.ts | 52 ++ tests/utils/page/actions.ts | 26 + tests/utils/page/locators.ts | 31 +- tests/utils/page/runner.ts | 16 +- 171 files changed, 7138 insertions(+), 1018 deletions(-) create mode 100644 packages/bruno-app/src/providers/ReduxStore/slices/collections/draft-collection-vars-isolation.spec.js create mode 100644 packages/bruno-app/src/providers/ReduxStore/slices/collections/draft-collection-vars-merge.spec.js create mode 100644 packages/bruno-app/src/providers/ReduxStore/slices/collections/draft-env-merge.spec.js create mode 100644 packages/bruno-app/src/providers/ReduxStore/slices/global-environments.spec.js create mode 100644 packages/bruno-electron/tests/store/env-secrets.spec.js create mode 100644 packages/bruno-js/tests/collectionVar.spec.js create mode 100644 packages/bruno-js/tests/globalEnvVar.spec.js create mode 100644 packages/bruno-tests/collection/scripting/api/bru/deleteEnvVar.bru create mode 100644 packages/bruno-tests/collection/scripting/api/bru/setGlobalEnvVar.bru create mode 100644 tests/environments/api-setCollectionVar/api-deleteCollectionVar.spec.ts create mode 100644 tests/environments/api-setCollectionVar/api-setCollectionVar-default-persistence.spec.ts create mode 100644 tests/environments/api-setCollectionVar/api-setCollectionVar-typed.spec.ts create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/api-deleteCollectionVar.bru create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/api-multi-persist-coll-vars.bru create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/api-setCollectionVar-default-persistence.bru create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/api-setCollectionVar-typed.bru create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/bruno.json create mode 100644 tests/environments/api-setCollectionVar/fixtures/collection/collection.bru create mode 100644 tests/environments/api-setCollectionVar/init-user-data/collection-security.json create mode 100644 tests/environments/api-setCollectionVar/init-user-data/preferences.json create mode 100644 tests/environments/api-setCollectionVar/multiple-persist-vars.spec.ts create mode 100644 tests/environments/api-setEnvVar-secret/api-setEnvVar-secret.spec.ts create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/bru/bruno.json create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/bru/environments/Local.bru create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/bru/read-secret.bru create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/bru/seed-secret.bru create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/bru/set-secret.bru create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/yml/environments/Local.yml create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/yml/opencollection.yml create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/yml/read-secret.yml create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/yml/seed-secret.yml create mode 100644 tests/environments/api-setEnvVar-secret/fixtures/collections/yml/set-secret.yml create mode 100644 tests/environments/api-setEnvVar-secret/init-user-data/collection-security.json create mode 100644 tests/environments/api-setEnvVar-secret/init-user-data/preferences.json delete mode 100644 tests/environments/api-setEnvVar/api-setEnvVar-without-persist.spec.ts create mode 100644 tests/environments/api-setEnvVar/api-setEnvVar.spec.ts rename tests/environments/api-setEnvVar/fixtures/collection/{api-setEnvVar-without-persist.bru => api-setEnvVar.bru} (79%) create mode 100644 tests/environments/api-setGlobalEnvVar-secret/api-setGlobalEnvVar-secret.spec.ts create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/collections/test-collection/bruno.json create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/collections/test-collection/read-global-secret.bru create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/collections/test-collection/seed-global-secret.bru create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/collections/test-collection/set-global-secret.bru create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/environments/Local.yml create mode 100644 tests/environments/api-setGlobalEnvVar-secret/fixtures/workspace/workspace.yml create mode 100644 tests/environments/api-setGlobalEnvVar-secret/init-user-data/collection-security.json create mode 100644 tests/environments/api-setGlobalEnvVar-secret/init-user-data/preferences.json create mode 100644 tests/environments/api-setGlobalEnvVar/api-setGlobalEnvVar-restart.spec.ts create mode 100644 tests/environments/api-setGlobalEnvVar/api-setGlobalEnvVar-typed-restart.spec.ts create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/collections/test-collection/bruno.json create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/collections/test-collection/read-global-var.bru create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/collections/test-collection/set-global-var.bru create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/collections/test-collection/set-typed-global-vars.bru create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/environments/Local.yml create mode 100644 tests/environments/api-setGlobalEnvVar/fixtures/workspace/workspace.yml create mode 100644 tests/environments/api-setGlobalEnvVar/init-user-data/collection-security.json create mode 100644 tests/environments/api-setGlobalEnvVar/init-user-data/preferences.json create mode 100644 tests/environments/collection-vars-draft-merge-with-script/collection-vars-draft-merge-with-script.spec.ts create mode 100644 tests/environments/collection-vars-draft-merge-with-script/fixtures/collections/collection-vars-draft-merge-test/bruno.json create mode 100644 tests/environments/collection-vars-draft-merge-with-script/fixtures/collections/collection-vars-draft-merge-test/collection.bru create mode 100644 tests/environments/collection-vars-draft-merge-with-script/fixtures/collections/collection-vars-draft-merge-test/environments/Test.bru create mode 100644 tests/environments/collection-vars-draft-merge-with-script/fixtures/collections/collection-vars-draft-merge-test/set-collection-var.bru create mode 100644 tests/environments/collection-vars-draft-merge-with-script/init-user-data/collection-security.json create mode 100644 tests/environments/collection-vars-draft-merge-with-script/init-user-data/preferences.json create mode 100644 tests/environments/draft-merge-with-script/draft-merge-with-script.spec.ts create mode 100644 tests/environments/draft-merge-with-script/fixtures/collections/draft-merge-test/bruno.json create mode 100644 tests/environments/draft-merge-with-script/fixtures/collections/draft-merge-test/environments/Test.bru create mode 100644 tests/environments/draft-merge-with-script/fixtures/collections/draft-merge-test/set-env-var.bru create mode 100644 tests/environments/draft-merge-with-script/init-user-data/collection-security.json create mode 100644 tests/environments/draft-merge-with-script/init-user-data/preferences.json create mode 100644 tests/environments/global-env-draft-merge-with-script/fixtures/collections/global-env-draft-merge-test/bruno.json create mode 100644 tests/environments/global-env-draft-merge-with-script/fixtures/collections/global-env-draft-merge-test/set-global-env-var.bru create mode 100644 tests/environments/global-env-draft-merge-with-script/global-env-draft-merge-with-script.spec.ts create mode 100644 tests/environments/global-env-draft-merge-with-script/init-user-data/collection-security.json create mode 100644 tests/environments/global-env-draft-merge-with-script/init-user-data/global-environments.json create mode 100644 tests/environments/global-env-draft-merge-with-script/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/collection-vars-draft-isolation.spec.ts create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/fixtures/collections/draft-isolation-test/bruno.json create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/fixtures/collections/draft-isolation-test/collection.bru create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/fixtures/collections/draft-isolation-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/fixtures/collections/draft-isolation-test/set-collection-var.bru create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/collection-vars-draft-isolation/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/fixtures/collections/global-env-var-persistence-typed-test/bruno.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/fixtures/collections/global-env-var-persistence-typed-test/set-typed-global-env-vars.bru create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/global-env-var-persistence-typed.spec.ts create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/init-user-data/global-environments.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence-typed/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence/fixtures/collections/global-env-var-persistence-test/bruno.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence/fixtures/collections/global-env-var-persistence-test/delete-global-env-var.bru create mode 100644 tests/scripting/bru-api/global-env-var-persistence/fixtures/collections/global-env-var-persistence-test/set-global-env-var.bru create mode 100644 tests/scripting/bru-api/global-env-var-persistence/global-env-var-persistence.spec.ts create mode 100644 tests/scripting/bru-api/global-env-var-persistence/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence/init-user-data/global-environments.json create mode 100644 tests/scripting/bru-api/global-env-var-persistence/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/fixtures/collections/variable-persistence-multi-request-test/bruno.json create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/fixtures/collections/variable-persistence-multi-request-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/fixtures/collections/variable-persistence-multi-request-test/req-1-write.bru create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/fixtures/collections/variable-persistence-multi-request-test/req-2-read-and-write.bru create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence-multi-request/variable-persistence-multi-request.spec.ts create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/fixtures/collections/variable-persistence-safe-test/bruno.json create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/fixtures/collections/variable-persistence-safe-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/fixtures/collections/variable-persistence-safe-test/set-collection-var.bru create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/fixtures/collections/variable-persistence-safe-test/set-env-var.bru create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence-safe-mode/variable-persistence-safe-mode.spec.ts create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/fixtures/collections/variable-persistence-typed-safe-test/bruno.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/fixtures/collections/variable-persistence-typed-safe-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/fixtures/collections/variable-persistence-typed-safe-test/set-typed-collection-vars.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/fixtures/collections/variable-persistence-typed-safe-test/set-typed-env-vars.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed-safe-mode/variable-persistence-typed-safe-mode.spec.ts create mode 100644 tests/scripting/bru-api/variable-persistence-typed/fixtures/collections/variable-persistence-typed-test/bruno.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed/fixtures/collections/variable-persistence-typed-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed/fixtures/collections/variable-persistence-typed-test/set-typed-collection-vars.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed/fixtures/collections/variable-persistence-typed-test/set-typed-env-vars.bru create mode 100644 tests/scripting/bru-api/variable-persistence-typed/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence-typed/variable-persistence-typed.spec.ts create mode 100644 tests/scripting/bru-api/variable-persistence/fixtures/collections/variable-persistence-test/bruno.json create mode 100644 tests/scripting/bru-api/variable-persistence/fixtures/collections/variable-persistence-test/environments/Test.bru create mode 100644 tests/scripting/bru-api/variable-persistence/fixtures/collections/variable-persistence-test/set-collection-var.bru create mode 100644 tests/scripting/bru-api/variable-persistence/fixtures/collections/variable-persistence-test/set-env-var.bru create mode 100644 tests/scripting/bru-api/variable-persistence/init-user-data/collection-security.json create mode 100644 tests/scripting/bru-api/variable-persistence/init-user-data/preferences.json create mode 100644 tests/scripting/bru-api/variable-persistence/variable-persistence.spec.ts diff --git a/packages/bruno-app/src/components/EnvironmentVariablesTable/index.js b/packages/bruno-app/src/components/EnvironmentVariablesTable/index.js index c07dbf671..7882d48a8 100644 --- a/packages/bruno-app/src/components/EnvironmentVariablesTable/index.js +++ b/packages/bruno-app/src/components/EnvironmentVariablesTable/index.js @@ -445,18 +445,7 @@ const EnvironmentVariablesTable = ({ const otherCurrent = namedValues.filter((variable) => !belongsToActiveTab(variable)); const otherSaved = savedValues.filter((variable) => !belongsToActiveTab(variable)); - // Compare against what's on disk: for an ephemeral overlay, that's - // `persistedValue`, not the scripted value Redux is holding. - const baselineForCompare = (v) => { - const stripped = stripEnvVarUid(v); - if (v?.ephemeral && v?.persistedValue !== undefined) { - stripped.value = v.persistedValue; - } - return stripped; - }; - // Compare without UIDs; only the active tab's subset decides if there's anything to save. - const hasChanges - = JSON.stringify(activeCurrent.map(stripEnvVarUid)) !== JSON.stringify(activeSaved.map(baselineForCompare)); + const hasChanges = JSON.stringify(activeCurrent.map(stripEnvVarUid)) !== JSON.stringify(activeSaved.map(stripEnvVarUid)); if (!hasChanges) { toast.error('No changes to save'); return; @@ -759,11 +748,6 @@ const EnvironmentVariablesTable = ({ isSecret={variable.secret} onChange={(newValue) => { formik.setFieldValue(`${actualIndex}.value`, newValue, true); - // Clear ephemeral metadata when user manually edits the value - if (variable.ephemeral) { - formik.setFieldValue(`${actualIndex}.ephemeral`, undefined, false); - formik.setFieldValue(`${actualIndex}.persistedValue`, undefined, false); - } // Append a new empty row when editing value on the last row if (isLastRow) { setTimeout(() => { diff --git a/packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js b/packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js index 94d036d6b..9a498f547 100644 --- a/packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js +++ b/packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js @@ -33,15 +33,15 @@ const ConfirmCloseEnvironment = ({ onCancel, onCloseWithoutSave, onSaveAndClose,
-
- -
diff --git a/packages/bruno-app/src/components/MultiLineEditor/index.js b/packages/bruno-app/src/components/MultiLineEditor/index.js index f22c6acaa..f9636b6f1 100644 --- a/packages/bruno-app/src/components/MultiLineEditor/index.js +++ b/packages/bruno-app/src/components/MultiLineEditor/index.js @@ -219,7 +219,7 @@ class MultiLineEditor extends Component { */ secretEye = (isSecret) => { return isSecret === true ? ( -