rayan/bruno
1
0
Fork 0
mirror of https://github.com/usebruno/bruno.git synced 2026-07-07 22:18:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix:serialize object variable values before copying to clipboard (#8362)

Browse Source 
* fix:serialize object variable values before copying to clipboard

* fix:guard JSON.stringify against circular and non-serializable object values

* refactor:added string helper function

* test:added playwright test

---------

Co-authored-by: Adwait Aayush <adwaitaayush@Adwaits-MacBook-Air.local>
This commit is contained in:
adwait-bruno
2026-07-01 20:19:17 +05:30
committed by GitHub
parent 4f31e9b073
commit 7b155c0e0a
5 changed files with 128 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
tests/variable-tooltip/variable-tooltip.spec.ts
View File

@@ -3,6 +3,8 @@ import {
createCollection,
closeAllCollections,
createRequest,
createFolder,
expandFolder,
createEnvironment,
addEnvironmentVariables,
saveEnvironment,
@@ -634,4 +636,84 @@ test.describe('Variable Tooltip', () => {
expect(updatedClipboard).toBe('original-copy-edited');
});
});
test('should copy pretty-printed JSON for an object-typed folder variable', async ({ page, createTmpDir }) => {
const collectionName = 'tooltip-object-copy-test';
const folderName = 'objFolder';
const objectValue = { city: 'NYC', zip: 10001 };
const expectedJson = JSON.stringify(objectValue, null, 2);
await test.step('Create a folder with an object-typed folder variable', async () => {
await createCollection(page, collectionName, await createTmpDir('tooltip-object-collection'));
await createFolder(page, folderName, collectionName);
const locators = buildCommonLocators(page);
// Open Folder Settings > Vars tab
const folderRow = locators.sidebar.folder(folderName);
await folderRow.dblclick();
await locators.paneTabs.folderSettingsTab('vars').click();
// Add the variable row and type its value
const tableContainer = page.getByTestId('folder-vars-req').first();
const lastRow = tableContainer.locator('tbody tr').last();
const nameInput = lastRow.locator('input[type="text"]').first();
await nameInput.click();
await page.keyboard.type('objVar');
const namedRow = tableContainer.locator('tbody tr[data-row-name="objVar"]');
await expect(namedRow).toBeVisible();
const valueEditor = namedRow.locator('[data-testid="column-value"] .CodeMirror').first();
await valueEditor.click({ force: true });
await expect(valueEditor).toHaveClass(/CodeMirror-focused/);
await page.keyboard.insertText(JSON.stringify(objectValue));
// Switch the variable's dataType from the default `string` to `object`
const typeTrigger = locators.dataTypeSelector.typeLabel(namedRow);
await typeTrigger.click();
await locators.dataTypeSelector.menuItem('object').click();
await expect(typeTrigger).toHaveText('object');
await page.getByRole('button', { name: 'Save', exact: true }).first().click();
await page.waitForTimeout(500);
});
await test.step('Create request inside the folder referencing the object variable', async () => {
await expandFolder(page, folderName);
await createRequest(page, 'Object Copy Request', folderName, { inFolder: true });
const locators = buildCommonLocators(page);
await locators.sidebar.folderRequest(folderName, 'Object Copy Request').click();
const urlEditor = page.locator('#request-url .CodeMirror');
await urlEditor.click();
await page.keyboard.type('https://api.example.com?data={{objVar}}');
await page.keyboard.press(saveShortcut);
});
await test.step('Tooltip shows pretty-printed JSON and copy button copies it verbatim', async () => {
const urlEditor = page.locator('#request-url .CodeMirror');
const objVar = urlEditor.locator('.cm-variable-valid').filter({ hasText: 'objVar' }).first();
await objVar.hover();
const tooltip = page.locator('.CodeMirror-brunoVarInfo').first();
await expect(tooltip).toBeVisible();
await expect(tooltip.locator('.var-scope-badge')).toContainText('Folder');
// Parse back and deep-compare so the assertion isn't coupled to whitespace.
const valueDisplay = tooltip.locator('.var-value-editable-display');
await expect.poll(async () => JSON.parse((await valueDisplay.textContent()) ?? 'null')).toEqual(objectValue);
const copyButton = tooltip.locator('.copy-button');
await copyButton.click();
// Success state confirms writeText resolved before we read the clipboard.
await expect(copyButton.locator('svg polyline')).toBeVisible({ timeout: 1000 });
const clipboardText = await page.evaluate(() => navigator.clipboard.readText());
expect(clipboardText).toBe(expectedJson);
});
});
});