diff --git a/playwright/index.ts b/playwright/index.ts index 95a57a39d..4f76482ae 100644 --- a/playwright/index.ts +++ b/playwright/index.ts @@ -76,13 +76,17 @@ async function usePageWithTracing( */ export async function closeElectronApp(app: ElectronApplication) { try { - await app.evaluate(({ app }) => { + await app.evaluate(async ({ app }) => { app.emit('before-quit'); + + // Add a delay to ensure the app is fully closed + await new Promise((resolve) => setTimeout(resolve, 250)); app.exit(0); }); } catch { // Expected: process exited before the CDP response was sent } + try { await app.close(); } catch { diff --git a/tests/environments/api-setEnvVar/api-setEnvVar-with-persist.spec.ts b/tests/environments/api-setEnvVar/api-setEnvVar-with-persist.spec.ts index 49f97b18c..7efe1eb1f 100644 --- a/tests/environments/api-setEnvVar/api-setEnvVar-with-persist.spec.ts +++ b/tests/environments/api-setEnvVar/api-setEnvVar-with-persist.spec.ts @@ -1,4 +1,4 @@ -import { test, expect } from '../../../playwright'; +import { test, expect, closeElectronApp } from '../../../playwright'; import { sendRequest } from '../../utils/page'; test.describe.serial('bru.setEnvVar(name, value, { persist: true })', () => { @@ -55,6 +55,6 @@ test.describe.serial('bru.setEnvVar(name, value, { persist: true })', () => { await newEnvTab.hover(); await newEnvTab.getByTestId('request-tab-close-icon').click({ force: true }); - await newPage.close(); + await closeElectronApp(newApp); }); }); diff --git a/tests/environments/api-setEnvVar/api-setEnvVar-without-persist.spec.ts b/tests/environments/api-setEnvVar/api-setEnvVar-without-persist.spec.ts index d5916b3af..acefe59d7 100644 --- a/tests/environments/api-setEnvVar/api-setEnvVar-without-persist.spec.ts +++ b/tests/environments/api-setEnvVar/api-setEnvVar-without-persist.spec.ts @@ -1,4 +1,4 @@ -import { test, expect } from '../../../playwright'; +import { test, expect, closeElectronApp } from '../../../playwright'; import { sendRequest } from '../../utils/page'; test.describe.serial('bru.setEnvVar(name, value)', () => { @@ -49,6 +49,6 @@ test.describe.serial('bru.setEnvVar(name, value)', () => { await newEnvTab.hover(); await newEnvTab.getByTestId('request-tab-close-icon').click({ force: true }); - await newPage.close(); + await closeElectronApp(newApp); }); }); diff --git a/tests/environments/collection-env-config-selection/init-user-data/preferences.json b/tests/environments/collection-env-config-selection/init-user-data/preferences.json index 3ee912651..fd66455e1 100644 --- a/tests/environments/collection-env-config-selection/init-user-data/preferences.json +++ b/tests/environments/collection-env-config-selection/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{projectRoot}}/tests/environments/collection-env-config-selection/collection" ] diff --git a/tests/environments/color-picker/init-user-data/preferences.json b/tests/environments/color-picker/init-user-data/preferences.json index 3fa671a0b..f0267b87f 100644 --- a/tests/environments/color-picker/init-user-data/preferences.json +++ b/tests/environments/color-picker/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{projectRoot}}/tests/environments/global-env-config-selection/collection" ] diff --git a/tests/environments/global-env-config-selection/init-user-data/preferences.json b/tests/environments/global-env-config-selection/init-user-data/preferences.json index 3fa671a0b..f0267b87f 100644 --- a/tests/environments/global-env-config-selection/init-user-data/preferences.json +++ b/tests/environments/global-env-config-selection/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{projectRoot}}/tests/environments/global-env-config-selection/collection" ] diff --git a/tests/environments/multiline-variables/init-user-data/preferences.json b/tests/environments/multiline-variables/init-user-data/preferences.json index 2b1b76811..09ebe3fd9 100644 --- a/tests/environments/multiline-variables/init-user-data/preferences.json +++ b/tests/environments/multiline-variables/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{collectionPath}}" ], diff --git a/tests/environments/update-global-environment-via-script/init-user-data/preferences.json b/tests/environments/update-global-environment-via-script/init-user-data/preferences.json index e3a4170d4..7972526a8 100644 --- a/tests/environments/update-global-environment-via-script/init-user-data/preferences.json +++ b/tests/environments/update-global-environment-via-script/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{projectRoot}}/tests/environments/update-global-environment-via-script/fixtures/collection" ] diff --git a/tests/interpolation/dynamic-variable/init-user-data/preferences.json b/tests/interpolation/dynamic-variable/init-user-data/preferences.json index 3b5b1cb6f..a22edd4c6 100644 --- a/tests/interpolation/dynamic-variable/init-user-data/preferences.json +++ b/tests/interpolation/dynamic-variable/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{projectRoot}}/tests/interpolation/dynamic-variable/collection" ] diff --git a/tests/preferences/default-collection-location/init-user-data/preferences.json b/tests/preferences/default-collection-location/init-user-data/preferences.json index fa1553037..9d0a76c50 100644 --- a/tests/preferences/default-collection-location/init-user-data/preferences.json +++ b/tests/preferences/default-collection-location/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/preferences/default-collection-location/collection"], "preferences": { "general": { diff --git a/tests/protobuf/init-user-data/preferences.json b/tests/protobuf/init-user-data/preferences.json index 62074fd28..2c2a33e57 100644 --- a/tests/protobuf/init-user-data/preferences.json +++ b/tests/protobuf/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": [ "{{collectionPath}}" ], diff --git a/tests/runner/init-user-data/preferences.json b/tests/runner/init-user-data/preferences.json index 4ab7e9620..7cdcb455f 100644 --- a/tests/runner/init-user-data/preferences.json +++ b/tests/runner/init-user-data/preferences.json @@ -1,4 +1,4 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/packages/bruno-tests/collection"] } \ No newline at end of file diff --git a/tests/ssl/basic-ssl/tests/basic-ssl-success/init-user-data/preferences.json b/tests/ssl/basic-ssl/tests/basic-ssl-success/init-user-data/preferences.json index 6552b27b8..d9db41de2 100644 --- a/tests/ssl/basic-ssl/tests/basic-ssl-success/init-user-data/preferences.json +++ b/tests/ssl/basic-ssl/tests/basic-ssl-success/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/basic-ssl/collections/badssl"], "preferences": { "request": { diff --git a/tests/ssl/basic-ssl/tests/self-signed-rejected/init-user-data/preferences.json b/tests/ssl/basic-ssl/tests/self-signed-rejected/init-user-data/preferences.json index 52696e791..01b80c882 100644 --- a/tests/ssl/basic-ssl/tests/self-signed-rejected/init-user-data/preferences.json +++ b/tests/ssl/basic-ssl/tests/self-signed-rejected/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/basic-ssl/collections/self-signed-badssl"], "preferences": { "request": { diff --git a/tests/ssl/basic-ssl/tests/self-signed-success-with-validation-disabled/init-user-data/preferences.json b/tests/ssl/basic-ssl/tests/self-signed-success-with-validation-disabled/init-user-data/preferences.json index a03d40903..18bdcde58 100644 --- a/tests/ssl/basic-ssl/tests/self-signed-success-with-validation-disabled/init-user-data/preferences.json +++ b/tests/ssl/basic-ssl/tests/self-signed-success-with-validation-disabled/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/basic-ssl/collections/self-signed-badssl"], "preferences": { "request": { diff --git a/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config-with-defaults/init-user-data/preferences.json b/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config-with-defaults/init-user-data/preferences.json index 452b90b10..97d33b6c2 100644 --- a/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config-with-defaults/init-user-data/preferences.json +++ b/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config-with-defaults/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/custom-ca-certs/collection"], "preferences": { "request": { diff --git a/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config/init-user-data/preferences.json b/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config/init-user-data/preferences.json index a1f944aa7..e44028b6b 100644 --- a/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config/init-user-data/preferences.json +++ b/tests/ssl/custom-ca-certs/tests/custom-invalid-ca-cert-in-config/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/custom-ca-certs/collection"], "preferences": { "request": { diff --git a/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config-with-defaults/init-user-data/preferences.json b/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config-with-defaults/init-user-data/preferences.json index b252fec6b..744a5b04c 100644 --- a/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config-with-defaults/init-user-data/preferences.json +++ b/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config-with-defaults/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/custom-ca-certs/collection"], "preferences": { "request": { diff --git a/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config/init-user-data/preferences.json b/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config/init-user-data/preferences.json index 33608d333..bfdc6b012 100644 --- a/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config/init-user-data/preferences.json +++ b/tests/ssl/custom-ca-certs/tests/custom-valid-ca-cert-in-config/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/custom-ca-certs/collection"], "preferences": { "request": { diff --git a/tests/ssl/custom-ca-certs/tests/wss-success/init-user-data/preferences.json b/tests/ssl/custom-ca-certs/tests/wss-success/init-user-data/preferences.json index 5a1df08ed..49f89458e 100644 --- a/tests/ssl/custom-ca-certs/tests/wss-success/init-user-data/preferences.json +++ b/tests/ssl/custom-ca-certs/tests/wss-success/init-user-data/preferences.json @@ -1,5 +1,5 @@ { - "maximized": true, + "maximized": false, "lastOpenedCollections": ["{{projectRoot}}/tests/ssl/custom-ca-certs/tests/wss-success/fixtures/wss-collection"], "preferences": { "request": {