From 71cf1a8f269ff67a325817e24cd6493089f01c54 Mon Sep 17 00:00:00 2001 From: Pragadesh-45 <54320162+Pragadesh-45@users.noreply.github.com> Date: Mon, 15 Dec 2025 19:13:33 +0530 Subject: [PATCH] fix: include request URL in prompt variable extraction and add tests (#6412) --- .../src/providers/ReduxStore/slices/collections/actions.js | 1 + .../collection/http-folder/http-request-without-ca.bru | 2 +- .../prompt-variables/http-request-prompt-variables.spec.ts | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js index 3f6dc3c92..994926373 100644 --- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js +++ b/packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js @@ -478,6 +478,7 @@ const extractPromptVariablesForRequest = async (item, collection) => { prompts.push(...extractPromptVariables(headers)); prompts.push(...extractPromptVariables(request.params)); prompts.push(...extractPromptVariables(resolvedAuthRequest.auth)); + prompts.push(...extractPromptVariables(request.url)); // Remove duplicates const uniquePrompts = Array.from(new Set(prompts)); diff --git a/tests/interpolation/prompt-variables/fixtures/collection/http-folder/http-request-without-ca.bru b/tests/interpolation/prompt-variables/fixtures/collection/http-folder/http-request-without-ca.bru index 1c27bf4f6..e8dde80f9 100644 --- a/tests/interpolation/prompt-variables/fixtures/collection/http-folder/http-request-without-ca.bru +++ b/tests/interpolation/prompt-variables/fixtures/collection/http-folder/http-request-without-ca.bru @@ -5,7 +5,7 @@ meta { } post { - url: http://localhost:8081/api/echo/json?query={{?Enter Query Variable}} + url: http://localhost:{{?Enter Port Variable}}/api/echo/json?query={{?Enter Query Variable}} body: json auth: inherit } diff --git a/tests/interpolation/prompt-variables/http-request-prompt-variables.spec.ts b/tests/interpolation/prompt-variables/http-request-prompt-variables.spec.ts index 6f9a38146..e8f11c284 100644 --- a/tests/interpolation/prompt-variables/http-request-prompt-variables.spec.ts +++ b/tests/interpolation/prompt-variables/http-request-prompt-variables.spec.ts @@ -32,7 +32,7 @@ test.describe('Prompt Variables Interpolation', () => { await test.step('Verify duplicate prompt variables are not allowed', async () => { // Enter the prompt variables promptInputs = promptVariablesModal.getByTestId('prompt-variable-input-container'); - await expect(promptInputs).toHaveCount(11); + await expect(promptInputs).toHaveCount(12); }); await test.step('Verify disabled / non selected modes prompt variables are not prompted', async () => { @@ -46,6 +46,7 @@ test.describe('Prompt Variables Interpolation', () => { }); await test.step('Fill the prompt variables and send the request', async () => { + await promptInputs.filter({ hasText: 'Enter Port Variable' }).locator('input').fill('8081'); await promptInputs.filter({ hasText: 'Enter Query Variable' }).locator('input').fill('queryPromptValue'); await promptInputs.filter({ hasText: 'Enter Body Variable' }).locator('input').fill('bodyPromptValue'); await promptInputs.filter({ hasText: 'Enter Number Variable' }).locator('input').fill('123');