From dbf1cad124211945638c264c50a0ca86cdcbe735 Mon Sep 17 00:00:00 2001 From: Pragadesh-45 Date: Wed, 15 Jan 2025 19:57:06 +0530 Subject: [PATCH] fix: remove `removeQuotes()` --- packages/bruno-js/src/sandbox/quickjs/index.js | 18 ++++++++++-------- packages/bruno-js/src/utils.js | 14 ++++++++------ 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/packages/bruno-js/src/sandbox/quickjs/index.js b/packages/bruno-js/src/sandbox/quickjs/index.js index d5fe5e8f3..35a4ee28b 100644 --- a/packages/bruno-js/src/sandbox/quickjs/index.js +++ b/packages/bruno-js/src/sandbox/quickjs/index.js @@ -22,12 +22,12 @@ const toNumber = (value) => { return Number.isInteger(num) ? parseInt(value, 10) : parseFloat(value); }; -const removeQuotes = (str) => { - if ((str.startsWith('"') && str.endsWith('"')) || (str.startsWith("'") && str.endsWith("'"))) { - return str.slice(1, -1); - } - return str; -}; +// const removeQuotes = (str) => { +// if ((str.startsWith('"') && str.endsWith('"')) || (str.startsWith("'") && str.endsWith("'"))) { +// return str.slice(1, -1); +// } +// return str; +// }; const executeQuickJsVm = ({ script: externalScript, context: externalContext, scriptType = 'template-literal' }) => { if (!externalScript?.length || typeof externalScript !== 'string') { @@ -44,7 +44,8 @@ const executeQuickJsVm = ({ script: externalScript, context: externalContext, sc if (externalScript === 'null') return null; if (externalScript === 'undefined') return undefined; - externalScript = removeQuotes(externalScript); + // This is commented out as part of the fix for #3758 + // externalScript = removeQuotes(externalScript); const vm = QuickJSSyncContext; @@ -94,7 +95,8 @@ const executeQuickJsVmAsync = async ({ script: externalScript, context: external if (externalScript === 'null') return null; if (externalScript === 'undefined') return undefined; - externalScript = removeQuotes(externalScript); + // This is commented out as part of the fix for #3758 + // externalScript = removeQuotes(externalScript); try { const module = await newQuickJSWASMModule(); diff --git a/packages/bruno-js/src/utils.js b/packages/bruno-js/src/utils.js index 55b454d02..32fa9d9be 100644 --- a/packages/bruno-js/src/utils.js +++ b/packages/bruno-js/src/utils.js @@ -85,13 +85,15 @@ const evaluateJsTemplateLiteral = (templateLiteral, context) => { return undefined; } - if (templateLiteral.startsWith('"') && templateLiteral.endsWith('"')) { - return templateLiteral.slice(1, -1); - } + // This is commented out as part of the fix for #3758 + // if (templateLiteral.startsWith('"') && templateLiteral.endsWith('"')) { + // return templateLiteral.slice(1, -1); + // } - if (templateLiteral.startsWith("'") && templateLiteral.endsWith("'")) { - return templateLiteral.slice(1, -1); - } + // This is commented out as part of the fix for #3758 + // if (templateLiteral.startsWith("'") && templateLiteral.endsWith("'")) { + // return templateLiteral.slice(1, -1); + // } if (!isNaN(templateLiteral)) { const number = Number(templateLiteral);