From 38bb1857966362ada0cb021916e121e97a803f7a Mon Sep 17 00:00:00 2001 From: Bijin A B Date: Mon, 11 May 2026 19:58:08 +0530 Subject: [PATCH] chore: remove timeouts --- .../collection-reorder-persistence.spec.ts | 13 ++++--------- .../create-workspace/create-workspace.spec.ts | 2 -- .../default-workspace/default-workspace.spec.ts | 2 -- tests/workspace/default-workspace/migration.spec.ts | 2 -- .../default-workspace/recovery-and-backup.spec.ts | 2 -- 5 files changed, 4 insertions(+), 17 deletions(-) diff --git a/tests/workspace/collection-reorder-persistence.spec.ts b/tests/workspace/collection-reorder-persistence.spec.ts index 3124823e9..a32d9b4a5 100644 --- a/tests/workspace/collection-reorder-persistence.spec.ts +++ b/tests/workspace/collection-reorder-persistence.spec.ts @@ -1,14 +1,12 @@ import path from 'path'; import fs from 'fs'; import yaml from 'js-yaml'; -import { test, expect } from '../../playwright'; +import { test, expect, closeElectronApp } from '../../playwright'; import { createCollection, waitForReadyPage } from '../utils/page'; type WorkspaceConfig = { collections?: { name: string }[] }; test.describe('Collection reorder persistence', () => { - test.setTimeout(90000); - test('reordered collection order persists after app restart', async ({ launchElectronApp, createTmpDir }) => { const userDataPath = await createTmpDir('collection-reorder-persistence'); const colAPath = await createTmpDir('col-a'); @@ -40,8 +38,7 @@ test.describe('Collection reorder persistence', () => { }); await test.step('Close app', async () => { - await app.context().close(); - await app.close(); + await closeElectronApp(app); }); await test.step('Restart app and verify order persisted', async () => { @@ -52,8 +49,7 @@ test.describe('Collection reorder persistence', () => { await expect(rows2.nth(0)).toContainText('ColB'); await expect(rows2.nth(1)).toContainText('ColA'); - await app2.context().close(); - await app2.close(); + await closeElectronApp(app2); }); }); @@ -76,8 +72,7 @@ test.describe('Collection reorder persistence', () => { }); await test.step('Close app', async () => { - await app.context().close(); - await app.close(); + await closeElectronApp(app); }); await test.step('Verify workspace.yml has ColB before ColA', async () => { diff --git a/tests/workspace/create-workspace/create-workspace.spec.ts b/tests/workspace/create-workspace/create-workspace.spec.ts index abb4a8d06..28f019178 100644 --- a/tests/workspace/create-workspace/create-workspace.spec.ts +++ b/tests/workspace/create-workspace/create-workspace.spec.ts @@ -24,8 +24,6 @@ function findCreatedWorkspaceDirs(location: string): string[] { } test.describe('Create Workspace', () => { - test.setTimeout(90000); - test.describe('Inline Creation Flow', () => { test('should create workspace via inline rename and press Enter', async ({ launchElectronApp, createTmpDir }) => { const wsLocation = await createTmpDir('ws-location-enter'); diff --git a/tests/workspace/default-workspace/default-workspace.spec.ts b/tests/workspace/default-workspace/default-workspace.spec.ts index 244208f8e..cd92ea646 100644 --- a/tests/workspace/default-workspace/default-workspace.spec.ts +++ b/tests/workspace/default-workspace/default-workspace.spec.ts @@ -4,8 +4,6 @@ import { test, expect, closeElectronApp } from '../../../playwright'; import { waitForReadyPage } from '../../utils/page'; test.describe('Default Workspace', () => { - test.setTimeout(90000); - test.describe('First Launch', () => { test('should create default workspace with "My Workspace" name on first launch', async ({ launchElectronApp, createTmpDir }) => { const userDataPath = await createTmpDir('default-workspace-first-launch'); diff --git a/tests/workspace/default-workspace/migration.spec.ts b/tests/workspace/default-workspace/migration.spec.ts index ee8832186..ec55d2c26 100644 --- a/tests/workspace/default-workspace/migration.spec.ts +++ b/tests/workspace/default-workspace/migration.spec.ts @@ -8,8 +8,6 @@ const env = { }; test.describe('Default Workspace Migration', () => { - test.setTimeout(90000); - test.describe('Migration from lastOpenedCollections', () => { test('should migrate collections from lastOpenedCollections to new workspace', async ({ launchElectronApp, createTmpDir }) => { const userDataPath = await createTmpDir('default-workspace-migration'); diff --git a/tests/workspace/default-workspace/recovery-and-backup.spec.ts b/tests/workspace/default-workspace/recovery-and-backup.spec.ts index beaa12d33..d32fb22c4 100644 --- a/tests/workspace/default-workspace/recovery-and-backup.spec.ts +++ b/tests/workspace/default-workspace/recovery-and-backup.spec.ts @@ -4,8 +4,6 @@ import { test, expect, closeElectronApp } from '../../../playwright'; import { waitForReadyPage } from '../../utils/page'; test.describe('Default Workspace Recovery and Backup', () => { - test.setTimeout(90000); - test.describe('Global Environments Backup', () => { test('should create backup file for global environments during migration', async ({ launchElectronApp, createTmpDir }) => { const userDataPath = await createTmpDir('global-env-backup');