From 2ed51bb9840f807eef236cb6a1bd39a9399aa00c Mon Sep 17 00:00:00 2001 From: sreelakshmi-bruno Date: Fri, 22 Aug 2025 14:05:41 +0530 Subject: [PATCH] Fix global env issue on bulk import (#5396) --- .../EnvironmentSettings/ImportEnvironment/index.js | 7 +------ .../src/postman/postman-env-to-bruno-env.js | 1 + .../tests/postman/postman-env-to-bruno-env.spec.js | 7 ++++++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/ImportEnvironment/index.js b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/ImportEnvironment/index.js index 55d67946b..f28ce36e1 100644 --- a/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/ImportEnvironment/index.js +++ b/packages/bruno-app/src/components/GlobalEnvironments/EnvironmentSettings/ImportEnvironment/index.js @@ -25,12 +25,7 @@ const ImportEnvironment = ({ onClose }) => { } ) .map((environment) => { - let variables = environment?.variables?.map(v => ({ - ...v, - uid: uuid(), - type: 'text' - })); - dispatch(addGlobalEnvironment({ name: environment.name, variables })) + dispatch(addGlobalEnvironment({ name: environment.name, variables: environment.variables })) .then(() => { toast.success('Global Environment imported successfully'); }) diff --git a/packages/bruno-converters/src/postman/postman-env-to-bruno-env.js b/packages/bruno-converters/src/postman/postman-env-to-bruno-env.js index d9183cbfb..1b0a4bf36 100644 --- a/packages/bruno-converters/src/postman/postman-env-to-bruno-env.js +++ b/packages/bruno-converters/src/postman/postman-env-to-bruno-env.js @@ -15,6 +15,7 @@ const importPostmanEnvironmentVariables = (brunoEnvironment, values = []) => { name: (i.key ?? '').replace(invalidVariableCharacterRegex, '_'), value: i.value ?? '', enabled: i.enabled, + type: 'text', secret: isSecret(i.type) }; diff --git a/packages/bruno-converters/tests/postman/postman-env-to-bruno-env.spec.js b/packages/bruno-converters/tests/postman/postman-env-to-bruno-env.spec.js index 9421d3768..d1831b480 100644 --- a/packages/bruno-converters/tests/postman/postman-env-to-bruno-env.spec.js +++ b/packages/bruno-converters/tests/postman/postman-env-to-bruno-env.spec.js @@ -32,6 +32,7 @@ describe('postmanToBrunoEnvironment Function', () => { value: 'value1', enabled: true, secret: false, + type: 'text', uid: "mockeduuidvalue123456", }, { @@ -39,6 +40,7 @@ describe('postmanToBrunoEnvironment Function', () => { value: 'value2', enabled: false, secret: true, + type: 'text', uid: "mockeduuidvalue123456", }, ], @@ -85,6 +87,7 @@ describe('postmanToBrunoEnvironment Function', () => { value: '', enabled: true, secret: false, + type: 'text', uid: "mockeduuidvalue123456", }, { @@ -92,6 +95,7 @@ describe('postmanToBrunoEnvironment Function', () => { value: '', enabled: true, secret: false, + type: 'text', uid: "mockeduuidvalue123456", }, { @@ -99,7 +103,8 @@ describe('postmanToBrunoEnvironment Function', () => { value: '', enabled: true, secret: false, - uid: "mockeduuidvalue123456", + type: 'text', + uid: "mockeduuidvalue123456" } ], };