From 24a36bc3557f3a494759047430ba9f4f53c714ed Mon Sep 17 00:00:00 2001 From: "Siddharth Gelera (reaper)" Date: Thu, 6 Nov 2025 19:05:35 +0530 Subject: [PATCH] fix: ensure protocolVersion is a number in WebSocket options (#6013) --- packages/bruno-requests/src/ws/ws-client.js | 6 +++++- .../fixtures/collection/ws-test-request-with-subproto.bru | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/bruno-requests/src/ws/ws-client.js b/packages/bruno-requests/src/ws/ws-client.js index f0b11f164..32b11b079 100644 --- a/packages/bruno-requests/src/ws/ws-client.js +++ b/packages/bruno-requests/src/ws/ws-client.js @@ -67,7 +67,11 @@ class WsClient { }; if (protocolVersion) { - wsOptions.protocolVersion = protocolVersion; + // Force convert to number since `ws` doesn't do it for you + const asNumber = Number(protocolVersion); + if (!isNaN(asNumber)) { + wsOptions.protocolVersion = asNumber; + } } const wsConnection = new ws.WebSocket(parsedUrl.fullUrl, protocols, wsOptions); diff --git a/tests/websockets/fixtures/collection/ws-test-request-with-subproto.bru b/tests/websockets/fixtures/collection/ws-test-request-with-subproto.bru index dc9466bba..f59901394 100644 --- a/tests/websockets/fixtures/collection/ws-test-request-with-subproto.bru +++ b/tests/websockets/fixtures/collection/ws-test-request-with-subproto.bru @@ -13,6 +13,7 @@ ws { headers { Sec-WebSocket-Protocol: soap Sec-WebSocket-Protocol: mqtt + Sec-WebSocket-Version: 13 } body:ws {