From 21efded2bfaedd7150beecd70309a7e12c3dd555 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?YONGJAE=20LEE=20=28=EC=9D=B4=EC=9A=A9=EC=9E=AC=29?= Date: Mon, 22 Jun 2026 15:44:22 +0900 Subject: [PATCH] Await the websocket visibility assertion so it actually runs (#8317) The 'websocket requests are visible' test calls expect(page.locator(...)).toBeVisible() without awaiting it. A Playwright web-first matcher returns a Promise that polls and retries until the element matches or the timeout elapses. When the expect is not awaited the Promise is created and immediately discarded, so the assertion never runs and the test passes whether or not the request is visible in the sidebar. This is the sole assertion in that test, so the test gave no real coverage. The six other expect calls in the same file are already awaited, so this brings the line in line with the file's own idiom. Signed-off-by: YONGJAE LEE --- tests/websockets/connection.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/websockets/connection.spec.ts b/tests/websockets/connection.spec.ts index 1efe9bc8d..10e7b4295 100644 --- a/tests/websockets/connection.spec.ts +++ b/tests/websockets/connection.spec.ts @@ -8,7 +8,7 @@ test.describe.serial('websockets', () => { test('websocket requests are visible', async ({ pageWithUserData: page, restartApp }) => { await page.locator('#sidebar-collection-name').click(); - expect(page.locator('span.item-name').filter({ hasText: BRU_REQ_NAME })).toBeVisible(); + await expect(page.locator('span.item-name').filter({ hasText: BRU_REQ_NAME })).toBeVisible(); }); test('websocket connects', async ({ pageWithUserData: page, restartApp }) => {