mirror of
https://github.com/usebruno/bruno.git
synced 2026-07-08 22:45:25 +00:00
feat: variable descriptions (#8269)
* feat: add description column to various tables and enhance UI interactions - Introduced a description column in Headers, VarsTable, and other components to allow multi-line descriptions. - Added toggle buttons to show/hide the description column in relevant tables. - Updated EditableTable component to support dynamic row addition with customizable labels. - Enhanced UI for better user experience with consistent button styles and spacing adjustments. * chore: resize fix handles * fix: restrict column check for last index * refactor: remove unwanted style and fix bottom padding of the last child in the table row * tests: improve testability and fix impacted locators * tests: fix locators for value fields * fix: improve newline handling in description prefix * fix: ts changes * chore: remove redundant code and fix description roundtrip * chore: remove redundant check * tests(bru-lang): tests for description and annotation * test: improve locators and tests * tests: descriptions * chore: re-add description setup * fix: re-add description cols * chore: fix the double click reset * fix: account for hidden sidebar in request pane width calculation * refactor: ui/ux fixes for data type toggle * chore: inline common deps into bruno-lang and bruno-schema * chore: tests * chore: fix ux for descriptions * fix: layout for environment vars table * fix: ensure correct row selection for multipart file upload in tests * feat: enhance UID assignment for request headers and variables in collections * chore: simplify * chore: update pkg * chore: abstract the e2e utils * chore: fix exports * tests: fix locators for datatype vars * fix: ux issue with secrets in environment table * tests: update locators for collection headers and vars descriptions * tests: update locators to use data attributes for datatype selectors * chore: update default css width for actions column * chore: remove tooltip for string type warnings * fix: reduce name widths * refactor: update annotation serialization to use single-quote delimiters for descriptions * refactor(tests): simplify description formatting in jsonToEnv tests * feat: add multiline description escaping and unescaping functions with tests * refactor: clean up imports and improve multiline text block handling * refactor: update locators to use new test IDs for environment variable editors * refactor: streamline header input handling and improve environment variable row access * refactor: update e2e-test job to support self-hosted runners * refactor: update E2E test runner configuration to include e2e and macOS environments --------- Co-authored-by: Pragadesh-45 <temporaryg7904@gmail.com>
This commit is contained in:
@@ -0,0 +1,43 @@
|
||||
import * as fs from 'fs';
|
||||
import * as path from 'path';
|
||||
import { test, expect } from '../../../playwright';
|
||||
import { openRequest, selectRequestPaneTab } from '../../utils/page';
|
||||
import { buildCommonLocators } from '../../utils/page/locators';
|
||||
|
||||
const COLLECTION = 'req-description';
|
||||
const saveShortcut = process.platform === 'darwin' ? 'Meta+s' : 'Control+s';
|
||||
|
||||
test.describe('Request Description - Write (Assertions)', () => {
|
||||
test('writes a multiline description to a request assertion and persists it to the .bru file', async ({
|
||||
pageWithUserData: page,
|
||||
collectionFixturePath
|
||||
}) => {
|
||||
await openRequest(page, COLLECTION, 'request-with-descriptions');
|
||||
await selectRequestPaneTab(page, 'Assert');
|
||||
|
||||
const assertionsTable = buildCommonLocators(page).table('assertions-table');
|
||||
const plainAssertRow = assertionsTable.rowByName('plainAssert');
|
||||
const descCell = plainAssertRow.getByTestId('column-description');
|
||||
|
||||
await descCell.evaluate((el) => {
|
||||
const cmEl = el.querySelector('.CodeMirror');
|
||||
if (!cmEl) throw new Error('No CodeMirror in plainAssert description cell');
|
||||
const cm = (cmEl as any).CodeMirror;
|
||||
if (!cm) throw new Error('CodeMirror instance not found');
|
||||
cm.setValue('First line\nSecond line');
|
||||
});
|
||||
|
||||
await expect(descCell.locator('.CodeMirror-line').nth(0)).toHaveText('First line');
|
||||
await expect(descCell.locator('.CodeMirror-line').nth(1)).toHaveText('Second line');
|
||||
|
||||
await page.keyboard.press(saveShortcut);
|
||||
await expect(page.getByText('Request saved successfully')).toBeVisible({ timeout: 5000 });
|
||||
|
||||
const bruPath = path.join(collectionFixturePath!, 'request-with-descriptions.bru');
|
||||
const fileContent = fs.readFileSync(bruPath, 'utf8');
|
||||
|
||||
expect(fileContent).toContain('@description');
|
||||
expect(fileContent).toContain('First line');
|
||||
expect(fileContent).toContain('Second line');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user