From d07106125052d560d1a256549cf5ccf645a9dd9a Mon Sep 17 00:00:00 2001 From: silverwind Date: Sat, 26 Feb 2022 11:14:23 +0100 Subject: [PATCH] Disable service worker by default (#18914) The service worker causes a lot of issues with JS errors after instance upgrades while not bringing any real performance gain over regular HTTP caching. Disable it by default for this reason. Maybe later we can remove it completely, as I simply see no benefit in having it. --- doc/advanced/config-cheat-sheet.en-us.md | 2 +- doc/developers/hacking-on-gitea.en-us.md | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/advanced/config-cheat-sheet.en-us.md b/doc/advanced/config-cheat-sheet.en-us.md index a7e5a622..6c290833 100644 --- a/doc/advanced/config-cheat-sheet.en-us.md +++ b/doc/advanced/config-cheat-sheet.en-us.md @@ -189,7 +189,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a add it to this config. - `DEFAULT_SHOW_FULL_NAME`: **false**: Whether the full name of the users should be shown where possible. If the full name isn't set, the username will be used. - `SEARCH_REPO_DESCRIPTION`: **true**: Whether to search within description at repository search on explore page. -- `USE_SERVICE_WORKER`: **true**: Whether to enable a Service Worker to cache frontend assets. +- `USE_SERVICE_WORKER`: **false**: Whether to enable a Service Worker to cache frontend assets. ### UI - Admin (`ui.admin`) diff --git a/doc/developers/hacking-on-gitea.en-us.md b/doc/developers/hacking-on-gitea.en-us.md index 6e9a98e1..56ee1ca3 100644 --- a/doc/developers/hacking-on-gitea.en-us.md +++ b/doc/developers/hacking-on-gitea.en-us.md @@ -185,8 +185,6 @@ Before committing, make sure the linters pass: make lint-frontend ``` -Note: When working on frontend code, set `USE_SERVICE_WORKER` to `false` in `app.ini` to prevent undesirable caching of frontend assets. - ### Configuring local ElasticSearch instance Start local ElasticSearch instance using docker: