mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-08-01 12:26:36 +00:00
3f7fd16ea1
An unchecked type assertion panics on input it did not expect, as a missing `tool_cache` key did in https://gitea.com/gitea/runner/pulls/1122.
Every flagged site is now handled where it can fail, or typed so it cannot: a `lock.Keyed` replaces the two `sync.Map` mutex registries, and the reporter's outputs carry an explicit sent flag. Mocks keep their assertions, a mismatch there is a setup error the panic names.
Bugs it turned up (only the first is reachable from workflows):
1. A scalar `matrix.include` or `matrix.exclude`, e.g. `include: foo` or `include: [1, 2]`, panicked the runner with `interface conversion: interface {} is string, not map[string]interface {}`. Verified against `main`, it is now a workflow error. `OnSchedule` panicked the same way on a malformed `on.schedule` entry.
1. `ExternalURL()` panicked on the nil listener after `Close()`, the port is now resolved once at startup.
1. `errors.Is(err, git.ErrShortRef)` followed by `err.(*git.Error)` panics as soon as anything wraps that error, so it is `errors.As` now.
1. An output name the server acknowledged without ever being sent one was recorded as sent forever, which silently dropped a later value for that name.
48576ab3e5 fixes one discovered issue: a matrix key holding a nested object was logged and then run as if the job had no matrix, so it now fails like an unknown `exclude` key.
Reviewed-on: https://gitea.com/gitea/runner/pulls/1123
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
82 lines
1.9 KiB
Go
82 lines
1.9 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// Copyright 2021 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package common
|
|
|
|
import (
|
|
"net"
|
|
"sort"
|
|
"strings"
|
|
)
|
|
|
|
// GetOutboundIP returns an outbound IP address of this machine.
|
|
// It tries to access the internet and returns the local IP address of the connection.
|
|
// If the machine cannot access the internet, it returns a preferred IP address from network interfaces.
|
|
// It returns nil if no IP address is found.
|
|
func GetOutboundIP() net.IP {
|
|
// See https://stackoverflow.com/a/37382208
|
|
conn, err := net.Dial("udp", "8.8.8.8:80")
|
|
if err == nil {
|
|
defer conn.Close()
|
|
if addr, ok := conn.LocalAddr().(*net.UDPAddr); ok {
|
|
return addr.IP
|
|
}
|
|
}
|
|
|
|
// So the machine cannot access the internet. Pick an IP address from network interfaces.
|
|
if ifs, err := net.Interfaces(); err == nil {
|
|
type IP struct {
|
|
net.IP
|
|
net.Interface
|
|
}
|
|
var ips []IP
|
|
for _, i := range ifs {
|
|
if addrs, err := i.Addrs(); err == nil {
|
|
for _, addr := range addrs {
|
|
var ip net.IP
|
|
switch v := addr.(type) {
|
|
case *net.IPNet:
|
|
ip = v.IP
|
|
case *net.IPAddr:
|
|
ip = v.IP
|
|
}
|
|
if ip.IsGlobalUnicast() {
|
|
ips = append(ips, IP{ip, i})
|
|
}
|
|
}
|
|
}
|
|
}
|
|
if len(ips) > 1 {
|
|
sort.Slice(ips, func(i, j int) bool {
|
|
ifi := ips[i].Interface
|
|
ifj := ips[j].Interface
|
|
|
|
// ethernet is preferred
|
|
if vi, vj := strings.HasPrefix(ifi.Name, "e"), strings.HasPrefix(ifj.Name, "e"); vi != vj {
|
|
return vi
|
|
}
|
|
|
|
ipi := ips[i].IP
|
|
ipj := ips[j].IP
|
|
|
|
// IPv4 is preferred
|
|
if vi, vj := ipi.To4() != nil, ipj.To4() != nil; vi != vj {
|
|
return vi
|
|
}
|
|
|
|
// en0 is preferred to en1
|
|
if ifi.Name != ifj.Name {
|
|
return ifi.Name < ifj.Name
|
|
}
|
|
|
|
// fallback
|
|
return ipi.String() < ipj.String()
|
|
})
|
|
return ips[0].IP
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|